Re: [PATCH 17/24] C6X: ptrace support

Arnd Bergmann
2011-08-22T21:08:16Z

On Monday 22 August 2011 16:09:38 Mark Salter wrote:
> + /*
> + * get all gp regs from the child.
> + */
> + case PTRACE_GETREGS:
> + return copy_regset_to_user(child, &user_c6x_native_view,
> + REGSET_GPR,
> + 0, NR_PTREGS * sizeof(long),
> + datap);
> +
> + /*
> + * set all gp regs in the child.
> + */
> + case PTRACE_SETREGS:
> + return copy_regset_from_user(child, &user_c6x_native_view,
> + REGSET_GPR,
> + 0, NR_PTREGS * sizeof(long),
> + datap);
> +
> + default:
> + ret = ptrace_request(child, request, addr, data);
> + break;

I noticed that you removed PTRACE_PEEKUSR and PTRACE_POKEUSR, and I also
noticed that you need special handling for PTRACE_POKETEXT. What about
PTRACE_GETREGS/PTRACE_SETREGS? Can the generic ptrace_request take care
of these as well? It seems to be the case on arch/openrisc.

Arnd