Re: [PATCH 04/24] C6X: build infrastructure

Mark Salter
2011-08-23T13:23:25Z

On Mon, 2011-08-22 at 22:55 +0200, Sam Ravnborg wrote:
> >
> > diff --git a/arch/c6x/Kconfig b/arch/c6x/Kconfig
> > new file mode 100644
> > index 0000000..f147a446
> > --- /dev/null
> > +++ b/arch/c6x/Kconfig
> > @@ -0,0 +1,179 @@
> > +#
> > +# For a description of the syntax of this configuration file,
> > +# see Documentation/kbuild/kconfig-language.txt.
> > +#
> > +
> > +config TMS320C6X
> > + def_bool y
> > + select CLKDEV_LOOKUP
> > + select GENERIC_HARDIRQS_NO__DO_IRQ
> > + select GENERIC_HARDIRQS_NO__DO_IRQ
> Not present in todays kernel - not even if you try to select it twice

Hmm, maybe it is true that I am stubborn.

>
> > + select GENERIC_HARDIRQS_NO_DEPRECATED
> Not present either - drop it.
>

okay, I'll get rid of these.

> > +
> > +menu "Processor type and features"
> > +
> > +config TMS320C64XPLUS
> > + bool "TMS320C64X+"
> A little help would be nice. Maybe with a pointer to a web-site.

okay.

>
> > +cflags-y := -D__linux__ -D__TMS320C6X__
>
> Why is __linux__ and __TMS3206C6X__ neeeded?
> and why are they not needed for CHECKFLAGS ?

I think these two defines were left over from trying to compensate
for differences between TI compiler and GCC. They aren't needed.

--Mark