Re: [PATCH 18/24] C6X: headers

Arnd Bergmann
2011-08-22T21:15:05Z

On Monday 22 August 2011 16:09:39 Mark Salter wrote:
> Signed-off-by: Mark Salter <msalter@redhat.com>

>
> diff --git a/arch/c6x/include/asm/asm-offsets.h b/arch/c6x/include/asm/asm-offsets.h
> new file mode 100644
> index 0000000..d370ee3
> --- /dev/null
> +++ b/arch/c6x/include/asm/asm-offsets.h
> @@ -0,0 +1 @@
> +#include <generated/asm-offsets.h>

I wonder if it makes sense to install this file in asm-generic/asm-offsets.h
and referencing it like the other files.

> +#include <asm-generic/bitops/hweight.h>

Do you have an instruction that can be used for hweight? That is often a useful
optimization.

Arnd