Re: [PATCH 23/24] C6X: Power and Sleep Controller

Mark Salter
2011-08-22T21:32:27Z

On Mon, 2011-08-22 at 23:20 +0200, Arnd Bergmann wrote:
> I think this should be a proper driver instead, using a struct platform_driver
> and a match table instead the hacky of_find_compatible_node. That is generally
> the preferred approach for any nonessential code that can be initialized later
> and is not referenced by core code. As far as I can tell, this is the case
> here, though I could not actually find the callers so far.

The soc-64*.c files are the only place using it right now. I think this
really should be wired into the clock code so clk_enable/disable control
the PSC states as well. At least that is what arm/mach-davinci does with
similar hardware. The PSC unit controls power to certain peripherals but
it also controls clock gating for some of them.

--Mark