Re: [PATCH v13 14/14] powerpc/64s/radix: Enable huge vmalloc mappings

Stephen Rothwell
2021-04-15T23:04:48Z

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

Hi all,

On Thu, 15 Apr 2021 11:55:29 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Thu, 15 Apr 2021 12:23:55 +0200 Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
> > > + * is done. STRICT_MODULE_RWX may require extra work to support this
> > > + * too.
> > > + */
> > >
> > > - return __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END, GFP_KERNEL,
> > > - PAGE_KERNEL_EXEC, VM_FLUSH_RESET_PERMS, NUMA_NO_NODE,
> >
> >
> > I think you should add the following in <asm/pgtable.h>
> >
> > #ifndef MODULES_VADDR
> > #define MODULES_VADDR VMALLOC_START
> > #define MODULES_END VMALLOC_END
> > #endif
> >
> > And leave module_alloc() as is (just removing the enclosing #ifdef MODULES_VADDR and adding the
> > VM_NO_HUGE_VMAP flag)
> >
> > This would minimise the conflits with the changes I did in powerpc/next reported by Stephen R.
> >
>
> I'll drop powerpc-64s-radix-enable-huge-vmalloc-mappings.patch for now,
> make life simpler.

I have dropped that patch from linux-next.
--
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]