Re: [PATCH v18 12/17] fprobe: Add fprobe_header encoding feature

Masami Hiramatsu
2024-11-12T23:43:34Z

On Tue, 12 Nov 2024 09:44:37 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sun, 10 Nov 2024 00:10:54 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>
> > > > +++ b/arch/x86/include/asm/fprobe.h
> > > > @@ -0,0 +1,9 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > > +#ifndef _ASM_X86_FPROBE_H
> > > > +#define _ASM_X86_FPROBE_H
> > > > +
> > > > +#ifdef CONFIG_64BIT
> > > > +#include <asm-generic/fprobe.h>
> > > > +#endif
> > > > +
> > > > +#endif /* _ASM_X86_FPROBE_H */
> > > > \ No newline at end of file
> > >
> > > Same for the above.
> >
> > OK, but x86 and riscv, we need this default template on 64bit only.
> > So those may keep it, right?
>
> Hmm, I wonder if we could just add:
>
> generic-$(CONFIG_X86_32)
>
> But since I don't see that used anywhere, we may need this for archs that
> partially have it.

Since this mask is not available on 32bit (since 32-4 = 28bit is 256MB,
which is too small for kernel space), I checked CONFIG_64BIT in
asm-generic header in v19. So now I can use generic-y for most
architecture.

Thank you,

>
> -- Steve

--
Masami Hiramatsu (Google) <mhiramat@kernel.org>