Re: [PATCH v21 03/20] fgraph: Replace fgraph_ret_regs with ftrace_regs

Steven Rostedt
2024-12-26T15:41:48Z

On Wed, 25 Dec 2024 22:33:00 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> diff --git a/arch/x86/kernel/ftrace_32.S b/arch/x86/kernel/ftrace_32.S
> index 8e1a27d2c1eb..f4e0c3361234 100644
> --- a/arch/x86/kernel/ftrace_32.S
> +++ b/arch/x86/kernel/ftrace_32.S
> @@ -194,8 +194,8 @@ return_to_handler:
> movl %esp, %eax
> call ftrace_return_to_handler
> movl %eax, %ecx
> - movl %eax, PT_EAX(%esp)
> - movl %edx, PT_EDX(%esp)
> + movl PT_EAX(%esp), %eax
> + movl PT_EDX(%esp), %edx
> addl $(PTREGS_SIZE), %esp
> JMP_NOSPEC ecx
> #endif

This appears to fix the issue. I'll start running your latest series
through my tests.

Thanks,

-- Steve