Re: [PATCH v21 03/20] fgraph: Replace fgraph_ret_regs with ftrace_regs

Heiko Carstens
2024-12-20T14:52:29Z

On Thu, Dec 19, 2024 at 04:34:48PM -0500, Steven Rostedt wrote:
> On Tue, 10 Dec 2024 11:09:26 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >
> > Use ftrace_regs instead of fgraph_ret_regs for tracing return value
> > on function_graph tracer because of simplifying the callback interface.
> >
> > The CONFIG_HAVE_FUNCTION_GRAPH_RETVAL is also replaced by
> > CONFIG_HAVE_FUNCTION_GRAPH_FREGS.
> >
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > Acked-by: Heiko Carstens <hca@linux.ibm.com>
>
> Did Heiko ack this? I don't see it in my inbox.

Yes, I did:
https://lore.kernel.org/lkml/20240916121656.20933-B-hca@linux.ibm.com/

> Heiko,
>
> Does the above look OK to you?

Looks still good to me.