Re: [PATCH v21 03/20] fgraph: Replace fgraph_ret_regs with ftrace_regs

Steven Rostedt
2024-12-20T15:08:17Z

On Fri, 20 Dec 2024 15:51:56 +0100
Heiko Carstens <hca@linux.ibm.com> wrote:

> On Thu, Dec 19, 2024 at 04:34:48PM -0500, Steven Rostedt wrote:
> > On Tue, 10 Dec 2024 11:09:26 +0900
> > "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> >
> > > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > >
> > > Use ftrace_regs instead of fgraph_ret_regs for tracing return value
> > > on function_graph tracer because of simplifying the callback interface.
> > >
> > > The CONFIG_HAVE_FUNCTION_GRAPH_RETVAL is also replaced by
> > > CONFIG_HAVE_FUNCTION_GRAPH_FREGS.
> > >
> > > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > > Acked-by: Heiko Carstens <hca@linux.ibm.com>
> >
> > Did Heiko ack this? I don't see it in my inbox.
>
> Yes, I did:
> https://lore.kernel.org/lkml/20240916121656.20933-B-hca@linux.ibm.com/

Oh OK. I didn't go back that far as it appeared you questioned this patch
in v16:

https://lore.kernel.org/all/20241016083323.16801-A-hca@linux.ibm.com/

>
> > Heiko,
> >
> > Does the above look OK to you?
>
> Looks still good to me.

Thanks, I'll likely pull in the series after rc4 and get it ready for
linux-next.

-- Steve