From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [RFC PATCH 5/6] x86/alternatives: use temporary mm for text poking Date: Wed, 29 Aug 2018 09:37:13 -0700 Message-ID: <17f2c74c-93fb-5ec8-4022-bd433fe0e429@intel.com> References: <20180829081147.184610-1-namit@vmware.com> <20180829081147.184610-6-namit@vmware.com> <20180829092839.GP24124@hirez.programming.kicks-ass.net> <20180829161400.GV24124@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Andy Lutomirski , Peter Zijlstra Cc: Nadav Amit , Thomas Gleixner , LKML , Ingo Molnar , X86 ML , Arnd Bergmann , linux-arch , Masami Hiramatsu , Kees Cook List-Id: linux-arch.vger.kernel.org On 08/29/2018 09:32 AM, Andy Lutomirski wrote: > It's plausible that there are workloads where the current code is > faster, such as where we're munmapping a single page via syscall and > we'd prefer to only flush that one TLB entry even if the flush > operation is slower as a result. Yeah, I don't specifically remember testing it. But, I know I wanted to avoid throwing away thousands of TLB entries when we only want to rid ourselves of one. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:15748 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727293AbeH2Ue6 (ORCPT ); Wed, 29 Aug 2018 16:34:58 -0400 Subject: Re: [RFC PATCH 5/6] x86/alternatives: use temporary mm for text poking References: <20180829081147.184610-1-namit@vmware.com> <20180829081147.184610-6-namit@vmware.com> <20180829092839.GP24124@hirez.programming.kicks-ass.net> <20180829161400.GV24124@hirez.programming.kicks-ass.net> From: Dave Hansen Message-ID: <17f2c74c-93fb-5ec8-4022-bd433fe0e429@intel.com> Date: Wed, 29 Aug 2018 09:37:13 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andy Lutomirski , Peter Zijlstra Cc: Nadav Amit , Thomas Gleixner , LKML , Ingo Molnar , X86 ML , Arnd Bergmann , linux-arch , Masami Hiramatsu , Kees Cook Message-ID: <20180829163713.W51wbh3tCWUPA2pbzkP5h28n7v4A5RMhN8zEU8PTHsI@z> On 08/29/2018 09:32 AM, Andy Lutomirski wrote: > It's plausible that there are workloads where the current code is > faster, such as where we're munmapping a single page via syscall and > we'd prefer to only flush that one TLB entry even if the flush > operation is slower as a result. Yeah, I don't specifically remember testing it. But, I know I wanted to avoid throwing away thousands of TLB entries when we only want to rid ourselves of one.