From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.ocs.com.au ([202.147.117.210]:34501 "EHLO mail.ocs.com.au") by vger.kernel.org with ESMTP id S1161084AbWFVLrI (ORCPT ); Thu, 22 Jun 2006 07:47:08 -0400 From: Keith Owens Subject: Re: [patch 2.6.17] Standardize i386/x86_64 handling of NMI_VECTOR In-reply-to: Your message of "Thu, 22 Jun 2006 12:48:21 +0200." <200606221248.21834.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 22 Jun 2006 21:46:38 +1000 Message-ID: <18463.1150976798@ocs3.ocs.com.au> Sender: linux-arch-owner@vger.kernel.org To: Andi Kleen Cc: linux-arch@vger.kernel.org List-ID: Andi Kleen (on Thu, 22 Jun 2006 12:48:21 +0200) wrote: >On Thursday 22 June 2006 11:01, Keith Owens wrote: >> x86_64 and i386 behave inconsistently when sending an IPI on vector 2 >> (NMI_VECTOR). Make both behave the same, so IPI 2 is sent as NMI. >> >> The crash code was abusing send_IPI_allbutself() by passing a code >> instead of a vector, it only worked because crash knew about the >> internal code of send_IPI_allbutself(). Change crash to use NMI_VECTOR >> instead, and remove the comment about how crash was abusing the function. > >Does that fix anything? This patch is a pre-requisite for fixing the problem where sending an IPI as NMI would reboot some Dell Xeon systems. I cannot fix that problem while crash continus to abuse send_IPI_allbutself(). It also removes the inconsistency between i386 and x86_64 for NMI_VECTOR. That will simplify all the RAS code that needs to bring all the cpus to a clean stop, even when one or more cpus are spinning disabled.