From: Guo Ren <ren_guo@c-sky.com>
To: akpm@linux-foundation.org, arnd@arndb.de,
daniel.lezcano@linaro.org, davem@davemloft.net,
gregkh@linuxfoundation.org, jason@lakedaemon.net,
marc.zyngier@arm.com, mark.rutland@arm.com,
mchehab+samsung@kernel.org, peterz@infradead.org,
robh@kernel.org, robh+dt@kernel.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
devicetree@vger.kernel.org, green.hu@gmail.com,
Guo Ren <ren_guo@c-sky.com>
Subject: [PATCH V6 33/33] csky: use asm-generic/bitops/atomic.h for all
Date: Fri, 28 Sep 2018 08:51:30 +0800 [thread overview]
Message-ID: <1b9d599bf69cdb47d4f40bc72b3ee906adad7ca9.1538058840.git.ren_guo@c-sky.com> (raw)
In-Reply-To: <62098e7d0a7fbdd09f44d7e23333dad258a01bd2.1538058840.git.ren_guo@c-sky.com>
In-Reply-To: <cover.1538058840.git.ren_guo@c-sky.com>
Specific implementation do not improve the performance, fall
back to asm-generic/bitops/atomic.h.
Signed-off-by: Guo Ren <ren_guo@c-sky.com>
---
arch/csky/include/asm/bitops.h | 201 -----------------------------------------
1 file changed, 201 deletions(-)
diff --git a/arch/csky/include/asm/bitops.h b/arch/csky/include/asm/bitops.h
index c9834f1..5d2640b 100644
--- a/arch/csky/include/asm/bitops.h
+++ b/arch/csky/include/asm/bitops.h
@@ -68,208 +68,7 @@ static __always_inline unsigned long __fls(unsigned long x)
#include <asm-generic/bitops/sched.h>
#include <asm-generic/bitops/hweight.h>
#include <asm-generic/bitops/lock.h>
-
-#ifdef CONFIG_CPU_HAS_LDSTEX
-
-/*
- * set_bit - Atomically set a bit in memory
- * @nr: the bit to set
- * @addr: the address to start counting from
- *
- * This function is atomic and may not be reordered. See __set_bit()
- * if you do not require the atomic guarantees.
- *
- * Note: there are no guarantees that this function will not be reordered
- * on non x86 architectures, so if you are writing portable code,
- * make sure not to rely on its reordering guarantees.
- *
- * Note that @nr may be almost arbitrarily large; this function is not
- * restricted to acting on a single-word quantity.
- */
-static inline void set_bit(int nr, volatile unsigned long *addr)
-{
- unsigned long mask = BIT_MASK(nr);
- unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
- unsigned long tmp;
-
- /* *p |= mask; */
- smp_mb();
- asm volatile (
- "1: ldex.w %0, (%2) \n"
- " or32 %0, %0, %1 \n"
- " stex.w %0, (%2) \n"
- " bez %0, 1b \n"
- : "=&r"(tmp)
- : "r"(mask), "r"(p)
- : "memory");
- smp_mb();
-}
-
-/**
- * clear_bit - Clears a bit in memory
- * @nr: Bit to clear
- * @addr: Address to start counting from
- *
- * clear_bit() is atomic and may not be reordered. However, it does
- * not contain a memory barrier, so if it is used for locking purposes,
- * you should call smp_mb__before_atomic() and/or smp_mb__after_atomic()
- * in order to ensure changes are visible on other processors.
- */
-static inline void clear_bit(int nr, volatile unsigned long *addr)
-{
- unsigned long mask = BIT_MASK(nr);
- unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
- unsigned long tmp;
-
- /* *p &= ~mask; */
- mask = ~mask;
- smp_mb();
- asm volatile (
- "1: ldex.w %0, (%2) \n"
- " and32 %0, %0, %1 \n"
- " stex.w %0, (%2) \n"
- " bez %0, 1b \n"
- : "=&r"(tmp)
- : "r"(mask), "r"(p)
- : "memory");
- smp_mb();
-}
-
-/**
- * change_bit - Toggle a bit in memory
- * @nr: Bit to change
- * @addr: Address to start counting from
- *
- * change_bit() is atomic and may not be reordered. It may be
- * reordered on other architectures than x86.
- * Note that @nr may be almost arbitrarily large; this function is not
- * restricted to acting on a single-word quantity.
- */
-static inline void change_bit(int nr, volatile unsigned long *addr)
-{
- unsigned long mask = BIT_MASK(nr);
- unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
- unsigned long tmp;
-
- /* *p ^= mask; */
- smp_mb();
- asm volatile (
- "1: ldex.w %0, (%2) \n"
- " xor32 %0, %0, %1 \n"
- " stex.w %0, (%2) \n"
- " bez %0, 1b \n"
- : "=&r"(tmp)
- : "r"(mask), "r"(p)
- : "memory");
- smp_mb();
-}
-
-/**
- * test_and_set_bit - Set a bit and return its old value
- * @nr: Bit to set
- * @addr: Address to count from
- *
- * This operation is atomic and cannot be reordered.
- * It may be reordered on other architectures than x86.
- * It also implies a memory barrier.
- */
-static inline int test_and_set_bit(int nr, volatile unsigned long *addr)
-{
- unsigned long mask = BIT_MASK(nr);
- unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
- unsigned long old, tmp;
-
- /*
- * old = *p;
- * *p = old | mask;
- */
- smp_mb();
- asm volatile (
- "1: ldex.w %1, (%3) \n"
- " mov %0, %1 \n"
- " or32 %0, %0, %2 \n"
- " stex.w %0, (%3) \n"
- " bez %0, 1b \n"
- : "=&r"(tmp), "=&r"(old)
- : "r"(mask), "r"(p)
- : "memory");
- smp_mb();
-
- return (old & mask) != 0;
-}
-
-/**
- * test_and_clear_bit - Clear a bit and return its old value
- * @nr: Bit to clear
- * @addr: Address to count from
- *
- * This operation is atomic and cannot be reordered.
- * It can be reorderdered on other architectures other than x86.
- * It also implies a memory barrier.
- */
-static inline int test_and_clear_bit(int nr, volatile unsigned long *addr)
-{
- unsigned long mask = BIT_MASK(nr);
- unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
- unsigned long old, tmp, mask_not;
-
- /*
- * old = *p;
- * *p = old & ~mask;
- */
- smp_mb();
- mask_not = ~mask;
- asm volatile (
- "1: ldex.w %1, (%3) \n"
- " mov %0, %1 \n"
- " and32 %0, %0, %2 \n"
- " stex.w %0, (%3) \n"
- " bez %0, 1b \n"
- : "=&r"(tmp), "=&r"(old)
- : "r"(mask_not), "r"(p)
- : "memory");
-
- smp_mb();
-
- return (old & mask) != 0;
-}
-
-/**
- * test_and_change_bit - Change a bit and return its old value
- * @nr: Bit to change
- * @addr: Address to count from
- *
- * This operation is atomic and cannot be reordered.
- * It also implies a memory barrier.
- */
-static inline int test_and_change_bit(int nr, volatile unsigned long *addr)
-{
- unsigned long mask = BIT_MASK(nr);
- unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
- unsigned long old, tmp;
-
- /*
- * old = *p;
- * *p = old ^ mask;
- */
- smp_mb();
- asm volatile (
- "1: ldex.w %1, (%3) \n"
- " mov %0, %1 \n"
- " xor32 %0, %0, %2 \n"
- " stex.w %0, (%3) \n"
- " bez %0, 1b \n"
- : "=&r"(tmp), "=&r"(old)
- : "r"(mask), "r"(p)
- : "memory");
- smp_mb();
-
- return (old & mask) != 0;
-}
-
-#else
#include <asm-generic/bitops/atomic.h>
-#endif
/*
* bug fix, why only could use atomic!!!!
--
2.7.4
next prev parent reply other threads:[~2018-09-28 0:51 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 14:47 [PATCH V6 00/33] C-SKY(csky) Linux Kernel Port Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 01/33] csky: Build infrastructure Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-28 16:11 ` Christoph Hellwig
2018-09-28 16:11 ` Christoph Hellwig
2018-09-29 17:20 ` Guo Ren
2018-09-29 17:20 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 02/33] csky: defconfig Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 03/33] csky: Kernel booting Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-28 16:13 ` Christoph Hellwig
2018-09-28 16:13 ` Christoph Hellwig
2018-09-29 17:09 ` Guo Ren
2018-09-29 17:09 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 04/33] csky: Exception handling and mm-fault Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-28 16:15 ` Christoph Hellwig
2018-09-28 16:15 ` Christoph Hellwig
2018-09-29 17:07 ` Guo Ren
2018-09-29 17:07 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 05/33] csky: System Call Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-28 16:16 ` Christoph Hellwig
2018-09-28 16:16 ` Christoph Hellwig
2018-09-29 17:05 ` Guo Ren
2018-09-29 17:05 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 06/33] csky: Cache and TLB routines Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 07/33] csky: MMU and page table management Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 15:47 ` Christoph Hellwig
2018-09-27 15:47 ` Christoph Hellwig
2018-09-28 13:08 ` Guo Ren
2018-09-28 13:08 ` Guo Ren
2018-09-29 17:04 ` Guo Ren
2018-09-29 17:04 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 08/33] csky: Process management and Signal Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 19:50 ` Eric W. Biederman
2018-09-27 19:50 ` Eric W. Biederman
2018-09-28 13:10 ` Guo Ren
2018-09-28 13:10 ` Guo Ren
2018-09-29 17:01 ` Guo Ren
2018-09-29 17:01 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 09/33] csky: VDSO and rt_sigreturn Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 10/33] csky: IRQ handling Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 15:49 ` Christoph Hellwig
2018-09-27 15:49 ` Christoph Hellwig
2018-09-28 13:09 ` Guo Ren
2018-09-28 13:09 ` Guo Ren
2018-09-29 17:00 ` Guo Ren
2018-09-29 17:00 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 11/33] csky: Atomic operations Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 12/33] csky: ELF and module probe Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 13/33] csky: Library functions Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-28 16:20 ` Christoph Hellwig
2018-09-28 16:20 ` Christoph Hellwig
2018-09-29 17:00 ` Guo Ren
2018-09-29 17:00 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 14/33] csky: User access Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 15/33] csky: Debug and Ptrace GDB Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 16/33] csky: SMP support Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-27 14:47 ` [PATCH V6 17/33] csky: Misc headers Guo Ren
2018-09-27 14:47 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 18/33] dt-bindings: csky CPU Bindings Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 19/33] dt-bindings: Add vendor prefix for csky Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 20/33] csky/dma: fix up dma_mapping error Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 16:21 ` Christoph Hellwig
2018-09-28 16:21 ` Christoph Hellwig
2018-09-29 15:08 ` Guo Ren
2018-09-29 15:08 ` Guo Ren
2018-09-30 11:10 ` Guo Ren
2018-09-30 11:10 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 21/33] csky: remove irq_mapping from smp.c Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 22/33] irqchip: add C-SKY SMP interrupt controller Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 23/33] dt-bindings: interrupt-controller: C-SKY SMP intc Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 24/33] clocksource: add C-SKY SMP timer Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 25/33] dt-bindings: timer: C-SKY Multi-processor timer Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 26/33] MAINTAINERS: Add csky Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 27/33] dt-bindings: interrupt-controller: C-SKY APB intc Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 28/33] irqchip: add C-SKY APB bus interrupt controller Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 29/33] dt-bindings: timer: gx6605s SOC timer Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 30/33] clocksource: add gx6605s SOC system timer Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 31/33] csky: fix compile error in linux/bug.h with SMP enabled Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` [PATCH V6 32/33] csky: fix flush_cache_range and tlb_start_vma Guo Ren
2018-09-28 0:51 ` Guo Ren
2018-09-28 0:51 ` Guo Ren [this message]
2018-09-28 0:51 ` [PATCH V6 33/33] csky: use asm-generic/bitops/atomic.h for all Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b9d599bf69cdb47d4f40bc72b3ee906adad7ca9.1538058840.git.ren_guo@c-sky.com \
--to=ren_guo@c-sky.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=green.hu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).