From: "John Williams" <john.williams@petalogix.com>
To: monstr@monstr.eu
Cc: linux-kernel@vger.kernel.org, monstr@seznam.cz, arnd@arndb.de,
linux-arch@vger.kernel.org, stephen.neuendorffer@xilinx.com,
John.Linn@xilinx.com, matthew@wil.cx, will.newton@gmail.com,
drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au,
grant.likely@secretlab.ca, vapier.adi@gmail.com,
alan@lxorguk.ukuu.org.uk, hpa@zytor.com, lethal@linux-sh.org,
florian@openwrt.org
Subject: Re: [PATCH 19/58] microblaze_v5: early_printk support
Date: Wed, 9 Jul 2008 09:47:29 +1000 [thread overview]
Message-ID: <1d3f23370807081647y446534dp6db16f560e4e0a2d@mail.gmail.com> (raw)
In-Reply-To: <2aa1ac7891af57959237aae3addf4bbe607f55d7.1215517976.git.monstr@monstr.eu>
> +++ b/arch/microblaze/kernel/early_printk.c
> @@ -0,0 +1,130 @@
> +#ifdef CONFIG_EARLY_PRINTK
> +#define BASE_ADDR ((unsigned char *)CONFIG_EARLY_PRINTK_UARTLITE_ADDRESS)
This is a problem - default value of EARLY_PRINTK_UARTLITE_ADDRESS is
0x0, so by default the kernel will try to access a uartlite at 0x0
which is the reset vector! I know there is the test in the actual
output routine but it's not good to rely on that in the default case.
Can we either
#if CONFIG_EARLY_PRINTK_UARTLITE_ADDRESS==0
#warning EARLY_PRINTK address not set, disabling
...
#else
..
#endif
or query the OF subsystem (is it up yet?), and default to using the
first uartlite in the system for early printk?
John
next prev parent reply other threads:[~2008-07-08 23:47 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 11:59 microblaze_v5: Status message monstr
2008-07-08 11:59 ` [PATCH 01/58] microblaze_v5: Kconfig patches monstr
2008-07-08 11:59 ` [PATCH 02/58] microblaze_v5: Makefiles for Microblaze cpu monstr
2008-07-08 11:59 ` [PATCH 03/58] microblaze_v5: Cpuinfo handling monstr
2008-07-08 11:59 ` [PATCH 04/58] microblaze_v5: Open firmware files1 monstr
2008-07-08 11:59 ` [PATCH 05/58] microblaze_v5: Open firmware files2 monstr
2008-07-08 11:59 ` [PATCH 06/58] microblaze_v5: Open firmware common files monstr
2008-07-08 11:59 ` [PATCH 07/58] microblaze_v5: exception handling monstr
2008-07-08 11:59 ` [PATCH 08/58] microblaze_v5: Signal support monstr
2008-07-08 11:59 ` [PATCH 09/58] microblaze_v5: Interrupt handling, timer support, supported function monstr
2008-07-08 11:59 ` [PATCH 10/58] microblaze_v5: cache support monstr
2008-07-08 11:59 ` monstr
2008-07-08 11:59 ` [PATCH 11/58] microblaze_v5: Generic dts file for platforms monstr
2008-07-08 11:59 ` [PATCH 12/58] microblaze_v5: kernel modules support monstr
2008-07-08 11:59 ` [PATCH 13/58] microblaze_v5: lmb support monstr
2008-07-08 11:59 ` [PATCH 14/58] microblaze_v5: PVR support, cpuinfo support monstr
2008-07-08 11:59 ` [PATCH 15/58] microblaze_v5: defconfig file monstr
2008-07-08 11:59 ` [PATCH 16/58] microblaze_v5: head.S + linker script monstr
2008-07-08 11:59 ` [PATCH 17/58] microblaze_v5: supported function for memory - kernel/lib monstr
2008-07-08 11:59 ` [PATCH 18/58] microblaze_v5: checksum support monstr
2008-07-08 11:59 ` [PATCH 19/58] microblaze_v5: early_printk support monstr
2008-07-08 11:59 ` [PATCH 20/58] microblaze_v5: uaccess files monstr
2008-07-08 11:59 ` [PATCH 21/58] microblaze_v5: heartbeat file monstr
2008-07-08 11:59 ` [PATCH 22/58] microblaze_v5: setup.c - system setting monstr
2008-07-08 11:59 ` [PATCH 23/58] microblaze_v5: asm-offsets monstr
2008-07-08 11:59 ` [PATCH 24/58] microblaze_v5: process and init task function monstr
2008-07-08 11:59 ` [PATCH 25/58] microblaze_v5: time support monstr
2008-07-08 11:59 ` [PATCH 26/58] microblaze_v5: virtualization monstr
2008-07-08 11:59 ` [PATCH 27/58] microblaze_v5: ptrace support monstr
2008-07-08 11:59 ` [PATCH 28/58] microblaze_v5: traps support monstr
2008-07-08 11:59 ` [PATCH 29/58] microblaze_v5: memory inicialization, MMU, TLB monstr
2008-07-08 11:59 ` [PATCH 30/58] microblaze_v5: page.h, segment.h, unaligned.h monstr
2008-07-08 11:59 ` [PATCH 31/58] microblaze_v5: includes SHM*, msgbuf monstr
2008-07-08 11:59 ` [PATCH 32/58] microblaze_v5: bug headers files monstr
2008-07-08 11:59 ` [PATCH 33/58] microblaze_v5: definitions of types monstr
2008-07-08 11:59 ` [PATCH 34/58] microblaze_v5: ioctl support monstr
2008-07-08 11:59 ` [PATCH 35/58] microblaze_v5: io.h IO operations monstr
2008-07-08 11:59 ` [PATCH 36/58] microblaze_v5: headers for executables format FLAT, ELF monstr
2008-07-08 11:59 ` [PATCH 37/58] microblaze_v5: dma support monstr
2008-07-08 11:59 ` [PATCH 38/58] microblaze_v5: headers for irq monstr
2008-07-08 11:59 ` [PATCH 39/58] microblaze_v5: atomic.h bitops.h byteorder.h monstr
2008-07-08 11:59 ` [PATCH 40/58] microblaze_v5: headers pgalloc.h pgtable.h monstr
2008-07-08 11:59 ` [PATCH 41/58] microblaze_v5: system.h pvr.h processor.h monstr
2008-07-08 11:59 ` [PATCH 42/58] microblaze_v5: clinkage.h linkage.h sections.h kmap_types.h monstr
2008-07-08 11:59 ` [PATCH 43/58] microblaze_v5: stats headers monstr
2008-07-08 11:59 ` [PATCH 44/58] microblaze_v5: termbits.h termios.h monstr
2008-07-08 11:59 ` [PATCH 45/58] microblaze_v5: sigcontext.h siginfo.h monstr
2008-07-08 11:59 ` [PATCH 46/58] microblaze_v5: headers simple files - empty or redirect to asm-generic monstr
2008-07-08 11:59 ` [PATCH 47/58] microblaze_v5: headers files entry.h current.h mman.h registers.h sembuf.h monstr
2008-07-08 11:59 ` [PATCH 48/58] microblaze_v5: device.h param.h topology.h monstr
2008-07-08 11:59 ` [PATCH 49/58] microblaze_v5: pool.h socket.h monstr
2008-07-08 11:59 ` [PATCH 50/58] microblaze_v5: generic files sockios.h ucontext.h monstr
2008-07-08 11:59 ` [PATCH 51/58] microblaze_v5: setup.h string.h thread_info.h monstr
2008-07-08 11:59 ` [PATCH 52/58] microblaze_v5: Kbuild file monstr
2008-07-08 11:59 ` [PATCH 53/58] microblaze_v5: pci headers monstr
2008-07-08 11:59 ` [PATCH 54/58] microblaze_v5: IPC headers monstr
2008-07-08 11:59 ` [PATCH 55/58] microblaze_v5: entry.S monstr
2008-07-08 11:59 ` [PATCH 56/58] microblaze_v5: sys_microblaze.c monstr
2008-07-08 11:59 ` [PATCH 57/58] microblaze_v5: syscall_table.S and unistd.h monstr
2008-07-08 11:59 ` [PATCH 58/58] microblaze_v5: Enable drivers for Microblaze monstr
2008-07-08 23:47 ` John Williams [this message]
2008-07-08 19:43 ` microblaze_v5: Status message Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3f23370807081647y446534dp6db16f560e4e0a2d@mail.gmail.com \
--to=john.williams@petalogix.com \
--cc=John.Linn@xilinx.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=drepper@redhat.com \
--cc=florian@openwrt.org \
--cc=grant.likely@secretlab.ca \
--cc=hpa@zytor.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=monstr@seznam.cz \
--cc=stephen.neuendorffer@xilinx.com \
--cc=vapier.adi@gmail.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).