From: "David S. Miller" <davem@redhat.com>
To: Arun Sharma <arun.sharma@intel.com>
Cc: linux-arch@vger.kernel.org
Subject: Re: compat tasks and O_LARGEFILE
Date: Sat, 28 Feb 2004 15:56:26 -0800 [thread overview]
Message-ID: <20040228155626.4e45aaa6.davem@redhat.com> (raw)
In-Reply-To: <20040228015709.GB6897@intel.com>
On Fri, 27 Feb 2004 17:57:09 -0800
Arun Sharma <arun.sharma@intel.com> wrote:
> This code sequence in linux/fs/open.c:
...
> > #if BITS_PER_LONG != 32
> > flags |= O_LARGEFILE;
> > #endif
>
> is problematic for compat tasks. For eg: negative seeks can result in
> ~4GB files getting created.
>
> Are there any objections to letting a task reset this flag using a fcntl?
> There are some corner cases, such as what if the file pointer is already
> beyond 4GB etc, but I think they're solvable.
See arch/sparc64/kernel/sys_sparc32.c:sparc32_open(), old and known issue.
That piece of code belongs in fs/compat.c so that it isn't duplicated all
over.
next prev parent reply other threads:[~2004-02-28 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-28 1:57 compat tasks and O_LARGEFILE Arun Sharma
2004-02-28 23:56 ` David S. Miller [this message]
2004-02-29 2:38 ` Arun Sharma
2004-03-01 5:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040228155626.4e45aaa6.davem@redhat.com \
--to=davem@redhat.com \
--cc=arun.sharma@intel.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox