From: Matthew Wilcox <willy@debian.org>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: linux-arch@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [RFC] Implement dma_boundary in the generic device
Date: Sun, 29 Feb 2004 16:46:30 +0000 [thread overview]
Message-ID: <20040229164630.GH25779@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1078070182.1756.11.camel@mulgrave>
On Sun, Feb 29, 2004 at 09:56:21AM -0600, James Bottomley wrote:
> ===== drivers/scsi/hosts.c 1.96 vs edited =====
> --- 1.96/drivers/scsi/hosts.c Mon Dec 29 15:38:10 2003
> +++ edited/drivers/scsi/hosts.c Sun Feb 29 09:08:09 2004
> @@ -111,6 +111,9 @@
> if (!shost->shost_gendev.parent)
> shost->shost_gendev.parent = dev ? dev : &platform_bus;
>
> + if(dev)
<nitpick style=janitor> Space between "if" and "(" </nitpick>
> ===== include/linux/dma-mapping.h 1.1 vs edited =====
> --- 1.1/include/linux/dma-mapping.h Sat Dec 21 22:37:05 2002
> +++ edited/include/linux/dma-mapping.h Sun Feb 29 09:12:02 2004
> @@ -12,6 +12,15 @@
>
> #include <asm/dma-mapping.h>
>
> +#ifndef ARCH_HAS_DMA_SET_BOUNDARY
> +static inline void
> +dma_set_boundary(struct device *dev, u64 boundary)
> +{
> + dev->dma_boundary = boundary;
> +}
> +#endif
Don't all architectures want a limit to 4GB boundaries, to avoid crossing
the first 4GB?
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-02-29 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-29 15:56 [RFC] Implement dma_boundary in the generic device James Bottomley
2004-02-29 16:46 ` Matthew Wilcox [this message]
2004-02-29 16:52 ` James Bottomley
2004-03-01 11:46 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040229164630.GH25779@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=James.Bottomley@steeleye.com \
--cc=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox