From: Andi Kleen <ak@suse.de>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-arch@vger.kernel.org, awilliam@fc.hp.com
Subject: Re: disable_hlt()/enable_hlt() look racy
Date: Thu, 4 Mar 2004 18:11:23 +0100 [thread overview]
Message-ID: <20040304181123.3b21f357.ak@suse.de> (raw)
In-Reply-To: <200403041001.42725.bjorn.helgaas@hp.com>
On Thu, 4 Mar 2004 10:01:42 -0700
Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> Alex Williamson implemented disable_hlt()/enable_hlt() for ia64,
> and in the process, we noticed that the implementations on
> other architectures look racy because hlt_counter is not
> protected.
As far as I can see only the floppy driver calls it ever and
and it does so from inside an own spinlock.
But I agree that it's better to use atomic_t. I will do that
change for x86-64.
-Andi
prev parent reply other threads:[~2004-03-04 17:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-04 17:01 disable_hlt()/enable_hlt() look racy Bjorn Helgaas
2004-03-04 17:11 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040304181123.3b21f357.ak@suse.de \
--to=ak@suse.de \
--cc=awilliam@fc.hp.com \
--cc=bjorn.helgaas@hp.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox