public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-arch@vger.kernel.org, minyard@acm.org, roland@redhat.com
Subject: Re: signal-race-fix.patch
Date: Fri, 19 Mar 2004 14:12:58 -0800	[thread overview]
Message-ID: <20040319141258.338c91b1.davem@redhat.com> (raw)
In-Reply-To: <20040319120151.380dcbc9.akpm@osdl.org>

On Fri, 19 Mar 2004 12:01:51 -0800
Andrew Morton <akpm@osdl.org> wrote:

> We have an SMP race in the signal code.  A fix for x86 is below.  All archs
> need updating.

I think the fix may need fixing :-)

Now that we're passing a stack local k_sigaction into handle_signal()
the real sigaction is not being updated f.e. when SA_ONESHOT causes
ka->sa.sa_handler to be set to SIG_DFL.  Only the stack local copy
is going to be set like this, not the one in the signals struct which
is where it is needed.

I noticed this while coding up the sparc versions which I'll defer until
this is cleared up.

  reply	other threads:[~2004-03-19 22:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-19 20:01 signal-race-fix.patch Andrew Morton
2004-03-19 22:12 ` David S. Miller [this message]
2004-03-19 22:38   ` signal-race-fix.patch Corey Minyard
2004-03-19 22:42   ` signal-race-fix.patch Corey Minyard
2004-03-19 23:28     ` signal-race-fix.patch David S. Miller
2004-03-19 23:37       ` signal-race-fix.patch Corey Minyard
2004-03-19 23:49     ` signal-race-fix.patch David S. Miller
2004-03-20  0:10       ` signal-race-fix.patch Corey Minyard
2004-03-23 10:20         ` signal-race-fix.patch Andrew Morton
2004-03-23 18:43           ` signal-race-fix.patch David S. Miller
2004-03-23 19:35           ` signal-race-fix.patch Roland McGrath
2004-03-23 20:18             ` signal-race-fix.patch David S. Miller
2004-03-24  1:54           ` signal-race-fix.patch David Mosberger
2004-03-24  3:58             ` signal-race-fix.patch Roland McGrath
2004-03-24  6:59               ` signal-race-fix.patch David Mosberger
2004-03-24 21:53           ` signal-race-fix.patch David Mosberger
2004-03-25  0:31             ` signal-race-fix.patch Arun Sharma
2004-07-26 21:17           ` signal-race-fix.patch Corey Minyard
2004-07-26 21:22             ` signal-race-fix.patch Andrew Morton
2004-07-27  3:40               ` signal-race-fix.patch Corey Minyard
2004-07-27  4:57                 ` signal-race-fix.patch Andrew Morton
2004-03-20  0:46       ` signal-race-fix.patch Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040319141258.338c91b1.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox