From: "David S. Miller" <davem@redhat.com>
To: linux-arch@vger.kernel.org
Subject: sys32_mount bug
Date: Wed, 24 Mar 2004 00:25:18 -0800 [thread overview]
Message-ID: <20040324002518.11c9ffae.davem@redhat.com> (raw)
Systems using compat system calls will need this too.
We weren't handling a NULL 'type' argument to mount() properly,
f.e. this happens legitimately when changing the options of an
existing mount.
===== arch/sparc64/kernel/sys_sparc32.c 1.91 vs edited =====
--- 1.91/arch/sparc64/kernel/sys_sparc32.c Fri Mar 12 01:30:19 2004
+++ edited/arch/sparc64/kernel/sys_sparc32.c Wed Mar 24 00:21:16 2004
@@ -1481,13 +1481,12 @@
if (err)
goto out;
- if (!type_page) {
- err = -EINVAL;
- goto out;
+ if (type_page) {
+ is_smb = !strcmp((char *)type_page, SMBFS_NAME);
+ is_ncp = !strcmp((char *)type_page, NCPFS_NAME);
+ } else {
+ is_smb = is_ncp = 0;
}
-
- is_smb = !strcmp((char *)type_page, SMBFS_NAME);
- is_ncp = !strcmp((char *)type_page, NCPFS_NAME);
err = copy_mount_stuff_to_kernel((const void *)AA(data), &data_page);
if (err)
reply other threads:[~2004-03-24 8:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040324002518.11c9ffae.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox