public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
* sys32_mount bug
@ 2004-03-24  8:25 David S. Miller
  0 siblings, 0 replies; only message in thread
From: David S. Miller @ 2004-03-24  8:25 UTC (permalink / raw)
  To: linux-arch


Systems using compat system calls will need this too.

We weren't handling a NULL 'type' argument to mount() properly,
f.e. this happens legitimately when changing the options of an
existing mount.

===== arch/sparc64/kernel/sys_sparc32.c 1.91 vs edited =====
--- 1.91/arch/sparc64/kernel/sys_sparc32.c	Fri Mar 12 01:30:19 2004
+++ edited/arch/sparc64/kernel/sys_sparc32.c	Wed Mar 24 00:21:16 2004
@@ -1481,13 +1481,12 @@
 	if (err)
 		goto out;
 
-	if (!type_page) {
-		err = -EINVAL;
-		goto out;
+	if (type_page) {
+		is_smb = !strcmp((char *)type_page, SMBFS_NAME);
+		is_ncp = !strcmp((char *)type_page, NCPFS_NAME);
+	} else {
+		is_smb = is_ncp = 0;
 	}
-
-	is_smb = !strcmp((char *)type_page, SMBFS_NAME);
-	is_ncp = !strcmp((char *)type_page, NCPFS_NAME);
 
 	err = copy_mount_stuff_to_kernel((const void *)AA(data), &data_page);
 	if (err)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-03-24  8:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-24  8:25 sys32_mount bug David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox