* [patch 2.6] __ARCH_WANT_SYS_RT_SIGACTION
@ 2004-06-04 9:19 Ivan Kokshaysky
2004-06-04 21:19 ` David S. Miller
2004-06-04 22:58 ` David Mosberger
0 siblings, 2 replies; 5+ messages in thread
From: Ivan Kokshaysky @ 2004-06-04 9:19 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-arch
Recent syscall stubs cleanup broke alpha, as it has its own
version of sys_rt_sigaction().
This defines __ARCH_WANT_SYS_RT_SIGACTION for all architectures
except alpha, sparc and sparc64.
Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
diff -urpN 2.6-bk/include/asm-arm/unistd.h linux/include/asm-arm/unistd.h
--- 2.6-bk/include/asm-arm/unistd.h Fri Jun 4 11:16:34 2004
+++ linux/include/asm-arm/unistd.h Fri Jun 4 11:23:29 2004
@@ -466,6 +466,7 @@ type name(type1 arg1, type2 arg2, type3
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-arm26/unistd.h linux/include/asm-arm26/unistd.h
--- 2.6-bk/include/asm-arm26/unistd.h Fri Jun 4 11:16:34 2004
+++ linux/include/asm-arm26/unistd.h Fri Jun 4 11:22:04 2004
@@ -397,6 +397,7 @@ type name(type1 arg1, type2 arg2, type3
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-cris/unistd.h linux/include/asm-cris/unistd.h
--- 2.6-bk/include/asm-cris/unistd.h Fri Jun 4 11:17:43 2004
+++ linux/include/asm-cris/unistd.h Fri Jun 4 11:22:28 2004
@@ -314,6 +314,7 @@
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-h8300/unistd.h linux/include/asm-h8300/unistd.h
--- 2.6-bk/include/asm-h8300/unistd.h Fri Jun 4 11:16:34 2004
+++ linux/include/asm-h8300/unistd.h Fri Jun 4 11:23:02 2004
@@ -468,6 +468,7 @@ type name(atype a, btype b, ctype c, dty
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-i386/unistd.h linux/include/asm-i386/unistd.h
--- 2.6-bk/include/asm-i386/unistd.h Fri Jun 4 11:16:34 2004
+++ linux/include/asm-i386/unistd.h Fri Jun 4 11:20:42 2004
@@ -403,6 +403,7 @@ __syscall_return(type,__res); \
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-ia64/unistd.h linux/include/asm-ia64/unistd.h
--- 2.6-bk/include/asm-ia64/unistd.h Fri Jun 4 11:16:34 2004
+++ linux/include/asm-ia64/unistd.h Fri Jun 4 11:24:08 2004
@@ -274,6 +274,7 @@
# define __ARCH_WANT_SYS_OLDUMOUNT
# define __ARCH_WANT_SYS_SIGPENDING
# define __ARCH_WANT_SYS_SIGPROCMASK
+# define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#if !defined(__ASSEMBLY__) && !defined(ASSEMBLER)
diff -urpN 2.6-bk/include/asm-m68k/unistd.h linux/include/asm-m68k/unistd.h
--- 2.6-bk/include/asm-m68k/unistd.h Fri Jun 4 11:16:34 2004
+++ linux/include/asm-m68k/unistd.h Fri Jun 4 11:23:50 2004
@@ -359,6 +359,7 @@ __syscall_return(type,__res); \
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-m68knommu/unistd.h linux/include/asm-m68knommu/unistd.h
--- 2.6-bk/include/asm-m68knommu/unistd.h Fri Jun 4 11:16:34 2004
+++ linux/include/asm-m68knommu/unistd.h Fri Jun 4 11:23:43 2004
@@ -394,6 +394,7 @@ type name(atype a, btype b, ctype c, dty
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-mips/unistd.h linux/include/asm-mips/unistd.h
--- 2.6-bk/include/asm-mips/unistd.h Fri Jun 4 11:16:34 2004
+++ linux/include/asm-mips/unistd.h Fri Jun 4 11:24:18 2004
@@ -1091,6 +1091,7 @@ type name (atype a,btype b,ctype c,dtype
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
# ifndef __mips64
# define __ARCH_WANT_STAT64
# endif
diff -urpN 2.6-bk/include/asm-parisc/unistd.h linux/include/asm-parisc/unistd.h
--- 2.6-bk/include/asm-parisc/unistd.h Fri Jun 4 11:16:35 2004
+++ linux/include/asm-parisc/unistd.h Fri Jun 4 11:24:25 2004
@@ -899,6 +899,7 @@ type name(type1 arg1, type2 arg2, type3
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
/* mmap & mmap2 take 6 arguments */
diff -urpN 2.6-bk/include/asm-ppc/unistd.h linux/include/asm-ppc/unistd.h
--- 2.6-bk/include/asm-ppc/unistd.h Fri Jun 4 11:16:35 2004
+++ linux/include/asm-ppc/unistd.h Fri Jun 4 11:24:52 2004
@@ -402,6 +402,7 @@ type name(type1 arg1, type2 arg2, type3
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
/*
* Forking from kernel space will result in the child getting a new,
diff -urpN 2.6-bk/include/asm-ppc64/unistd.h linux/include/asm-ppc64/unistd.h
--- 2.6-bk/include/asm-ppc64/unistd.h Fri Jun 4 11:16:35 2004
+++ linux/include/asm-ppc64/unistd.h Fri Jun 4 11:24:34 2004
@@ -439,6 +439,7 @@ static inline _syscall3(int, execve, __c
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
unsigned long sys_mmap(unsigned long addr, size_t len, unsigned long prot,
unsigned long flags, unsigned long fd, off_t offset);
diff -urpN 2.6-bk/include/asm-s390/unistd.h linux/include/asm-s390/unistd.h
--- 2.6-bk/include/asm-s390/unistd.h Fri Jun 4 11:16:35 2004
+++ linux/include/asm-s390/unistd.h Fri Jun 4 11:23:12 2004
@@ -530,6 +530,7 @@ type name(type1 arg1, type2 arg2, type3
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
# ifndef CONFIG_ARCH_S390X
# define __ARCH_WANT_STAT64
# endif
diff -urpN 2.6-bk/include/asm-sh/unistd.h linux/include/asm-sh/unistd.h
--- 2.6-bk/include/asm-sh/unistd.h Fri Jun 4 11:16:35 2004
+++ linux/include/asm-sh/unistd.h Fri Jun 4 11:21:34 2004
@@ -422,6 +422,7 @@ __syscall_return(type,__sc0); \
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-um/unistd.h linux/include/asm-um/unistd.h
--- 2.6-bk/include/asm-um/unistd.h Fri Jun 4 11:16:35 2004
+++ linux/include/asm-um/unistd.h Fri Jun 4 11:23:36 2004
@@ -34,6 +34,7 @@ extern int um_execve(const char *file, c
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-v850/unistd.h linux/include/asm-v850/unistd.h
--- 2.6-bk/include/asm-v850/unistd.h Fri Jun 4 11:16:35 2004
+++ linux/include/asm-v850/unistd.h Fri Jun 4 11:21:53 2004
@@ -408,6 +408,7 @@ type name (atype a, btype b, ctype c, dt
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifdef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/include/asm-x86_64/unistd.h linux/include/asm-x86_64/unistd.h
--- 2.6-bk/include/asm-x86_64/unistd.h Fri Jun 4 11:16:35 2004
+++ linux/include/asm-x86_64/unistd.h Fri Jun 4 11:24:43 2004
@@ -591,6 +591,7 @@ do { \
#define __ARCH_WANT_SYS_OLDUMOUNT
#define __ARCH_WANT_SYS_SIGPENDING
#define __ARCH_WANT_SYS_SIGPROCMASK
+#define __ARCH_WANT_SYS_RT_SIGACTION
#endif
#ifndef __KERNEL_SYSCALLS__
diff -urpN 2.6-bk/kernel/signal.c linux/kernel/signal.c
--- 2.6-bk/kernel/signal.c Fri Jun 4 11:17:44 2004
+++ linux/kernel/signal.c Fri Jun 4 11:20:42 2004
@@ -2477,7 +2477,7 @@ out:
}
#endif /* __ARCH_WANT_SYS_SIGPROCMASK */
-#ifndef __sparc__
+#ifdef __ARCH_WANT_SYS_RT_SIGACTION
asmlinkage long
sys_rt_sigaction(int sig,
const struct sigaction __user *act,
@@ -2505,7 +2505,7 @@ sys_rt_sigaction(int sig,
out:
return ret;
}
-#endif /* __sparc__ */
+#endif /* __ARCH_WANT_SYS_RT_SIGACTION */
#ifdef __ARCH_WANT_SYS_SGETMASK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 2.6] __ARCH_WANT_SYS_RT_SIGACTION
2004-06-04 9:19 [patch 2.6] __ARCH_WANT_SYS_RT_SIGACTION Ivan Kokshaysky
@ 2004-06-04 21:19 ` David S. Miller
2004-06-04 22:58 ` David Mosberger
1 sibling, 0 replies; 5+ messages in thread
From: David S. Miller @ 2004-06-04 21:19 UTC (permalink / raw)
To: Ivan Kokshaysky; +Cc: akpm, linux-arch
On Fri, 4 Jun 2004 13:19:26 +0400
Ivan Kokshaysky <ink@jurassic.park.msu.ru> wrote:
> Recent syscall stubs cleanup broke alpha, as it has its own
> version of sys_rt_sigaction().
> This defines __ARCH_WANT_SYS_RT_SIGACTION for all architectures
> except alpha, sparc and sparc64.
>
> Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
I'm totally fine with this patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 2.6] __ARCH_WANT_SYS_RT_SIGACTION
2004-06-04 9:19 [patch 2.6] __ARCH_WANT_SYS_RT_SIGACTION Ivan Kokshaysky
2004-06-04 21:19 ` David S. Miller
@ 2004-06-04 22:58 ` David Mosberger
2004-06-06 9:55 ` Ivan Kokshaysky
1 sibling, 1 reply; 5+ messages in thread
From: David Mosberger @ 2004-06-04 22:58 UTC (permalink / raw)
To: Ivan Kokshaysky; +Cc: Andrew Morton, linux-arch
>>>>> On Fri, 4 Jun 2004 13:19:26 +0400, Ivan Kokshaysky <ink@jurassic.park.msu.ru> said:
Ivan> Recent syscall stubs cleanup broke alpha, as it has its own
Ivan> version of sys_rt_sigaction(). This defines
Ivan> __ARCH_WANT_SYS_RT_SIGACTION for all architectures except
Ivan> alpha, sparc and sparc64.
Sorry, that was my bad (obviously). I think the real problem is that
the closing #endif for __ARCH_WANT_SYS_SIGPROCMASK came too late (by
one function), so that sys_rt_sigaction() was accidentally left out if
this macro wasn't defined. The problem was fixed in Linus' tree
yesterday. Can you confirm that it builds on Alpha again as well?
Thanks,
--david
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 2.6] __ARCH_WANT_SYS_RT_SIGACTION
2004-06-04 22:58 ` David Mosberger
@ 2004-06-06 9:55 ` Ivan Kokshaysky
2004-06-07 18:32 ` David Mosberger
0 siblings, 1 reply; 5+ messages in thread
From: Ivan Kokshaysky @ 2004-06-06 9:55 UTC (permalink / raw)
To: davidm; +Cc: Andrew Morton, linux-arch
On Fri, Jun 04, 2004 at 03:58:37PM -0700, David Mosberger wrote:
> Sorry, that was my bad (obviously). I think the real problem is that
> the closing #endif for __ARCH_WANT_SYS_SIGPROCMASK came too late (by
> one function), so that sys_rt_sigaction() was accidentally left out if
> this macro wasn't defined. The problem was fixed in Linus' tree
> yesterday. Can you confirm that it builds on Alpha again as well?
No, it doesn't.
In fact, it was the very change that broke Alpha - we have
alpha-specific versions of *both* sys_sigprocmask() and
sys_rt_sigaction().
The patch still applies to today's bk tree.
Ivan.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 2.6] __ARCH_WANT_SYS_RT_SIGACTION
2004-06-06 9:55 ` Ivan Kokshaysky
@ 2004-06-07 18:32 ` David Mosberger
0 siblings, 0 replies; 5+ messages in thread
From: David Mosberger @ 2004-06-07 18:32 UTC (permalink / raw)
To: Ivan Kokshaysky; +Cc: davidm, Andrew Morton, linux-arch
>>>>> On Sun, 6 Jun 2004 13:55:12 +0400, Ivan Kokshaysky <ink@jurassic.park.msu.ru> said:
Ivan> On Fri, Jun 04, 2004 at 03:58:37PM -0700, David Mosberger wrote:
>> Can you confirm that it builds on Alpha again as well?
Ivan> No, it doesn't.
Ivan> In fact, it was the very change that broke Alpha - we have
Ivan> alpha-specific versions of *both* sys_sigprocmask() and
Ivan> sys_rt_sigaction().
Ivan> The patch still applies to today's bk tree.
Ah, I misunderstood the problem---the patch seems fine to me, then.
--david
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-06-07 18:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-04 9:19 [patch 2.6] __ARCH_WANT_SYS_RT_SIGACTION Ivan Kokshaysky
2004-06-04 21:19 ` David S. Miller
2004-06-04 22:58 ` David Mosberger
2004-06-06 9:55 ` Ivan Kokshaysky
2004-06-07 18:32 ` David Mosberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox