From: Russell King <rmk@arm.linux.org.uk>
To: linux-arch@vger.kernel.org
Subject: [PATCH 1/3] Provide console_device()
Date: Mon, 14 Jun 2004 13:45:02 +0100 [thread overview]
Message-ID: <20040614134502.C14403@flint.arm.linux.org.uk> (raw)
[This patch series will also appear on lkml shortly]
Add console_device() to return the console tty driver structure and the
index. Acquire the console lock while scanning the list of console
drivers to protect us against console driver list manipulations.
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x *.orig -x *.rej orig/drivers/char/tty_io.c linux/drivers/char/tty_io.c
--- orig/drivers/char/tty_io.c Wed Jun 9 00:51:02 2004
+++ linux/drivers/char/tty_io.c Mon Jun 14 10:55:28 2004
@@ -1344,13 +1344,8 @@ retry_open:
}
#endif
if (device == MKDEV(TTYAUX_MAJOR,1)) {
- struct console *c = console_drivers;
- for (c = console_drivers; c; c = c->next) {
- if (!c->device)
- continue;
- driver = c->device(c, &index);
- if (!driver)
- continue;
+ driver = console_device(&index);
+ if (driver) {
/* Don't let /dev/console block */
filp->f_flags |= O_NONBLOCK;
noctty = 1;
diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x *.orig -x *.rej orig/kernel/printk.c linux/kernel/printk.c
--- orig/kernel/printk.c Sun May 30 10:33:00 2004
+++ linux/kernel/printk.c Mon Jun 14 10:56:18 2004
@@ -683,6 +683,23 @@ void console_unblank(void)
}
EXPORT_SYMBOL(console_unblank);
+struct tty_driver *console_device(int *index)
+{
+ struct console *c;
+ struct tty_driver *driver = NULL;
+
+ acquire_console_sem();
+ for (c = console_drivers; c != NULL; c = c->next) {
+ if (!c->device)
+ continue;
+ driver = c->device(c, index);
+ if (driver)
+ break;
+ }
+ release_console_sem();
+ return driver;
+}
+
/*
* The console driver calls this routine during kernel initialization
* to register the console printing procedure with printk() and to
diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x *.orig -x *.rej orig/include/linux/console.h linux/include/linux/console.h
--- orig/include/linux/console.h Mon May 24 11:26:21 2004
+++ linux/include/linux/console.h Mon Jun 14 10:55:28 2004
@@ -104,6 +104,7 @@ extern void acquire_console_sem(void);
extern void release_console_sem(void);
extern void console_conditional_schedule(void);
extern void console_unblank(void);
+extern struct tty_driver *console_device(int *);
extern int is_console_locked(void);
/* Some debug stub to catch some of the obvious races in the VT code */
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next reply other threads:[~2004-06-14 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-14 12:45 Russell King [this message]
2004-06-14 12:45 ` [PATCH 1/3] Provide console_suspend() and console_resume() Russell King
2004-06-14 12:46 ` [RFC][PATCH 3/3] Convert console list to list_head Russell King
2004-06-14 14:02 ` Matthew Wilcox
2004-06-15 0:20 ` David S. Miller
2004-06-14 17:46 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040614134502.C14403@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox