public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] aacraid 32/64 ioctl support (update)
  2004-06-16 17:53           ` [PATCH] aacraid 32/64 ioctl support (update) Christoph Hellwig
@ 2004-06-16 17:52             ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-06-16 17:52 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: markh, James.Bottomley, linux-scsi, mark_salyzyn, linux-arch,
	linux-kernel

On Wed, 16 Jun 2004 18:53:25 +0100
Christoph Hellwig <hch@infradead.org> wrote:

> > I just noticed this.  Can we use memset on a user pointer?  If not, what
> > would be the best way to handle this?
> 
> 
> Good question.  Maybe the architecture-folks know an answer?

Use clear_user()

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] aacraid 32/64 ioctl support (update)
       [not found]         ` <1087408316.13488.93.camel@markh1.pdx.osdl.net>
@ 2004-06-16 17:53           ` Christoph Hellwig
  2004-06-16 17:52             ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-06-16 17:53 UTC (permalink / raw)
  To: Mark Haverkamp
  Cc: James Bottomley, linux-scsi, Mark Salyzyn, linux-arch,
	linux-kernel

> > Although the compat_alloc_user_space implementations I looked at don't fail I
> > think a check for NULL wouldn't hurt.
> 
> The places that I looked where they check the return value use
> access_ok().  What do you think?

 
> > > +	f = compat_alloc_user_space(sizeof(*f));
> 
> I just noticed this.  Can we use memset on a user pointer?  If not, what
> would be the best way to handle this?


Good question.  Maybe the architecture-folks know an answer?
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-06-16 17:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1087401137.13488.61.camel@markh1.pdx.osdl.net>
     [not found] ` <20040616160107.GA14144@infradead.org>
     [not found]   ` <20040616160232.GB14144@infradead.org>
     [not found]     ` <1087405920.13488.82.camel@markh1.pdx.osdl.net>
     [not found]       ` <20040616171924.GA15925@infradead.org>
     [not found]         ` <1087408316.13488.93.camel@markh1.pdx.osdl.net>
2004-06-16 17:53           ` [PATCH] aacraid 32/64 ioctl support (update) Christoph Hellwig
2004-06-16 17:52             ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox