From: Christoph Hellwig <hch@infradead.org>
To: Mark Haverkamp <markh@osdl.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Mark Salyzyn <mark_salyzyn@adaptec.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aacraid 32/64 ioctl support (update)
Date: Wed, 16 Jun 2004 18:53:25 +0100 [thread overview]
Message-ID: <20040616175325.GA16751@infradead.org> (raw)
In-Reply-To: <1087408316.13488.93.camel@markh1.pdx.osdl.net>
> > Although the compat_alloc_user_space implementations I looked at don't fail I
> > think a check for NULL wouldn't hurt.
>
> The places that I looked where they check the return value use
> access_ok(). What do you think?
> > > + f = compat_alloc_user_space(sizeof(*f));
>
> I just noticed this. Can we use memset on a user pointer? If not, what
> would be the best way to handle this?
Good question. Maybe the architecture-folks know an answer?
next parent reply other threads:[~2004-06-16 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1087401137.13488.61.camel@markh1.pdx.osdl.net>
[not found] ` <20040616160107.GA14144@infradead.org>
[not found] ` <20040616160232.GB14144@infradead.org>
[not found] ` <1087405920.13488.82.camel@markh1.pdx.osdl.net>
[not found] ` <20040616171924.GA15925@infradead.org>
[not found] ` <1087408316.13488.93.camel@markh1.pdx.osdl.net>
2004-06-16 17:53 ` Christoph Hellwig [this message]
2004-06-16 17:52 ` [PATCH] aacraid 32/64 ioctl support (update) David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040616175325.GA16751@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox