From: Arnd Bergmann <arnd@arndb.de>
To: Arun Sharma <arun.sharma@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@redhat.com>,
linux-arch@vger.kernel.org
Subject: Re: sys getdents64 needs compat wrapper ?
Date: Sun, 20 Jun 2004 23:50:19 +0200 [thread overview]
Message-ID: <200406202350.24106.arnd@arndb.de> (raw)
In-Reply-To: <40D320E2.9020806@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]
On Freitag, 18. Juni 2004 19:05, Arun Sharma wrote:
> Updated patch attached.
I now noticed one more bug:
> + * values at locations that are unknown to be aligned.
> + */
> +#define __get_user_unaligned(x, ptr) \
> +({ \
> + __typeof__ (*(ptr)) __x = (x); \
> + __copy_from_user(&__x, (ptr), sizeof(*(ptr))) ? -EFAULT : 0; \
> +})
The assignment is done in the wrong direction, this needs to become
something like:
#define __get_user_unaligned(x, ptr) \
({ \
__typeof__ (*(ptr)) __x; \
__copy_from_user(&__x, (ptr), sizeof(*(ptr))) ? -EFAULT : 0; \
(x) = __x; \
})
Hopefully that'll be the last change for this, the rest looks good to
me.
Arnd <><
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-06-20 21:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-20 21:06 =?iso-8859-1?Q?Re:_sys_getdents64_needs_compat_wrapper_??= Arnd Bergmann
2004-06-05 0:16 ` =?iso-8859-1?Q?Re:_sys_getdents64_needs_compat_wrapper_??= Arun Sharma
2004-06-05 0:28 ` sys getdents64 needs compat wrapper ? David S. Miller
2004-06-07 21:13 ` Arun Sharma
2004-06-07 21:58 ` David S. Miller
2004-06-11 15:09 ` Arnd Bergmann
2004-06-14 18:15 ` Arun Sharma
2004-06-17 22:28 ` Arun Sharma
2004-06-17 23:36 ` Arnd Bergmann
2004-06-18 0:56 ` Arun Sharma
2004-06-18 17:05 ` Arun Sharma
2004-06-20 21:50 ` Arnd Bergmann [this message]
2004-06-22 18:21 ` Arun Sharma
-- strict thread matches above, loose matches on Subject: below --
2004-06-05 14:52 =?iso-8859-1?Q?Re:_Re:_Re:_sys_getdents64_needs_compat_wrapper_??= Arnd Bergmann
2004-06-05 18:41 ` sys getdents64 needs compat wrapper ? Andrew Morton
2004-06-05 19:31 ` David S. Miller
2004-05-20 18:32 sys_getdents64 " Arun Sharma
2004-05-20 20:58 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406202350.24106.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=arun.sharma@intel.com \
--cc=davem@redhat.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox