Re: compat_sys_adjtimex

[Arnd Bergmann <arnd@arndb.de>]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

On Donnerstag, 1. Juli 2004 03:03, Arun Sharma wrote:
> 
> +struct compat_timex {
> +       u32 modes;
> +       s32 offset, freq, maxerror, esterror;
> +       s32 status, constant, precision, tolerance;
> +       struct compat_timeval time;
> +       s32 tick;
> +       s32 ppsfreq, jitter, shift, stabil;
> +       s32 jitcnt, calcnt, errcnt, stbcnt;
> +       s32  :32; s32  :32; s32  :32; s32  :32;
> +       s32  :32; s32  :32; s32  :32; s32  :32;
> +       s32  :32; s32  :32; s32  :32; s32  :32;
> +};
> +

I'd personally prefer to use type names like compat_ulong_t
in the place of u32 when the a member in the original struct
is unsigned long.

> +asmlinkage long compat_sys_adjtimex(struct compat_timex *utp)
> +
This is missing a semicolon.

I had done my own version of compat_sys_adjtimex and most of
the other sys32_* functions that are worth consolidating some time
ago. Unfortunately I never got around to bringing them into a
proper patch for for submission. Would you like to have my code
so you can finish it?
As an alternative approach I can prepare patches that simply
add the compat_sys_* functions and leave it to each arch maintainer
to remove their own versions.

	Arnd <><

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]