From: Andrew Morton <akpm@osdl.org>
To: linux-arch@vger.kernel.org
Subject: Re: find_next_bit return type
Date: Sat, 31 Jul 2004 23:25:43 -0700 [thread overview]
Message-ID: <20040731232543.39b37766.akpm@osdl.org> (raw)
In-Reply-To: <20040731232434.7263b50c.akpm@osdl.org>
x86_64:
diff -puN include/asm-x86_64/bitops.h~x86_64-bitops-fix include/asm-x86_64/bitops.h
--- 25/include/asm-x86_64/bitops.h~x86_64-bitops-fix 2004-07-31 22:30:52.417209120 -0700
+++ 25-akpm/include/asm-x86_64/bitops.h 2004-07-31 22:31:28.898663096 -0700
@@ -256,8 +256,8 @@ static __inline__ int variable_test_bit(
extern long find_first_zero_bit(const unsigned long * addr, unsigned long size);
extern long find_next_zero_bit (const unsigned long * addr, long size, long offset);
-extern long find_first_bit(const unsigned long * addr, unsigned long size);
-extern long find_next_bit(const unsigned long * addr, long size, long offset);
+extern int find_first_bit(const unsigned long * addr, unsigned long size);
+extern int find_next_bit(const unsigned long * addr, long size, long offset);
/*
* Find string of zero bits in a bitmap. -1 when not found.
diff -puN arch/x86_64/lib/bitops.c~x86_64-bitops-fix arch/x86_64/lib/bitops.c
--- 25/arch/x86_64/lib/bitops.c~x86_64-bitops-fix 2004-07-31 22:31:41.598732392 -0700
+++ 25-akpm/arch/x86_64/lib/bitops.c 2004-07-31 22:32:12.100095480 -0700
@@ -93,7 +93,7 @@ __find_first_bit(const unsigned long * a
* Returns the bit-number of the first set bit, not the number of the byte
* containing a bit.
*/
-long find_first_bit(const unsigned long * addr, unsigned long size)
+int find_first_bit(const unsigned long * addr, unsigned long size)
{
return __find_first_bit(addr,size);
}
@@ -104,7 +104,7 @@ long find_first_bit(const unsigned long
* @offset: The bitnumber to start searching at
* @size: The maximum size to search
*/
-long find_next_bit(const unsigned long * addr, long size, long offset)
+int find_next_bit(const unsigned long * addr, long size, long offset)
{
const unsigned long * p = addr + (offset >> 6);
unsigned long set = 0, bit = offset & 63, res;
_
next prev parent reply other threads:[~2004-08-01 6:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 6:24 find_next_bit return type Andrew Morton
2004-08-01 6:25 ` Andrew Morton
2004-08-01 6:58 ` David S. Miller
2004-08-01 7:02 ` Andrew Morton
2004-08-01 7:10 ` David S. Miller
2004-08-02 10:40 ` Andi Kleen
2004-08-01 6:25 ` Andrew Morton [this message]
2004-08-01 6:26 ` Andrew Morton
2004-08-01 11:53 ` William Lee Irwin III
2004-08-01 13:51 ` William Lee Irwin III
2004-08-01 15:05 ` James Bottomley
2004-08-01 15:07 ` William Lee Irwin III
2004-08-01 22:09 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040731232543.39b37766.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox