From: "David S. Miller" <davem@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-arch@vger.kernel.org
Subject: Re: find_next_bit return type
Date: Sat, 31 Jul 2004 23:58:24 -0700 [thread overview]
Message-ID: <20040731235824.249ddb23.davem@redhat.com> (raw)
In-Reply-To: <20040731232515.1fead83b.akpm@osdl.org>
It's kind of pukey that the size and offset passed in is
unsigned long yet the return type is 'int'.
Frankly, I think the 64-bit systems have the prototype correct
this time and x86 is what ought to be "fixed" :-)
Just think, it only takes a "4GB / 8" sized bitmap to
potentially overflow that int return value :)))
Come on Andrew, you had to cringe at least a smidgen when
making these diffs :)
next prev parent reply other threads:[~2004-08-01 6:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 6:24 find_next_bit return type Andrew Morton
2004-08-01 6:25 ` Andrew Morton
2004-08-01 6:58 ` David S. Miller [this message]
2004-08-01 7:02 ` Andrew Morton
2004-08-01 7:10 ` David S. Miller
2004-08-02 10:40 ` Andi Kleen
2004-08-01 6:25 ` Andrew Morton
2004-08-01 6:26 ` Andrew Morton
2004-08-01 11:53 ` William Lee Irwin III
2004-08-01 13:51 ` William Lee Irwin III
2004-08-01 15:05 ` James Bottomley
2004-08-01 15:07 ` William Lee Irwin III
2004-08-01 22:09 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040731235824.249ddb23.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox