* bug in syscal arg sign extension
@ 2004-08-27 1:08 David S. Miller
2004-08-27 15:52 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2004-08-27 1:08 UTC (permalink / raw)
To: linux-arch
Remember this topic long ago?
Anyways, there was a bug in my sparc64 code and it causes all
kinds of trouble for logging daemons. I was sign extending
the buffer pointer arg instead of the length arg to sys_syslog()
Ooops!
:-)
Fix attached in cases anyone was doing work for the platform
based upon my sparc64 stuff.
===== arch/sparc64/kernel/sys32.S 1.9 vs edited =====
--- 1.9/arch/sparc64/kernel/sys32.S 2004-06-03 14:51:21 -07:00
+++ edited/arch/sparc64/kernel/sys32.S 2004-08-26 17:49:39 -07:00
@@ -120,7 +120,7 @@
SIGN2(sys32_setpgid, sys_setpgid, %o0, %o1)
SIGN3(sys32_setpriority, sys_setpriority, %o0, %o1, %o2)
SIGN1(sys32_ssetmask, sys_ssetmask, %o0)
-SIGN2(sys32_syslog, sys_syslog, %o0, %o1)
+SIGN2(sys32_syslog, sys_syslog, %o0, %o2)
SIGN1(sys32_umask, sys_umask, %o0)
SIGN3(sys32_tgkill, sys_tgkill, %o0, %o1, %o2)
SIGN1(sys32_sendto, sys_sendto, %o0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug in syscal arg sign extension
2004-08-27 1:08 bug in syscal arg sign extension David S. Miller
@ 2004-08-27 15:52 ` Andi Kleen
2004-08-27 19:27 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2004-08-27 15:52 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-arch
On Thu, Aug 26, 2004 at 06:08:02PM -0700, David S. Miller wrote:
>
> Remember this topic long ago?
>
> Anyways, there was a bug in my sparc64 code and it causes all
> kinds of trouble for logging daemons. I was sign extending
> the buffer pointer arg instead of the length arg to sys_syslog()
> Ooops!
> :-)
>
> Fix attached in cases anyone was doing work for the platform
> based upon my sparc64 stuff.
Thanks for the hint. From a quick look at your list I think
there are several bugs on x86-64.
But some entries I don't understand. e.g. why are you sign
extending open or prctl?
-Andi
>
> ===== arch/sparc64/kernel/sys32.S 1.9 vs edited =====
> --- 1.9/arch/sparc64/kernel/sys32.S 2004-06-03 14:51:21 -07:00
> +++ edited/arch/sparc64/kernel/sys32.S 2004-08-26 17:49:39 -07:00
> @@ -120,7 +120,7 @@
> SIGN2(sys32_setpgid, sys_setpgid, %o0, %o1)
> SIGN3(sys32_setpriority, sys_setpriority, %o0, %o1, %o2)
> SIGN1(sys32_ssetmask, sys_ssetmask, %o0)
> -SIGN2(sys32_syslog, sys_syslog, %o0, %o1)
> +SIGN2(sys32_syslog, sys_syslog, %o0, %o2)
> SIGN1(sys32_umask, sys_umask, %o0)
> SIGN3(sys32_tgkill, sys_tgkill, %o0, %o1, %o2)
> SIGN1(sys32_sendto, sys_sendto, %o0)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-08-27 19:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-27 1:08 bug in syscal arg sign extension David S. Miller
2004-08-27 15:52 ` Andi Kleen
2004-08-27 19:27 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox