public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-arch@vger.kernel.org
Subject: x86-64-waitid-compat-fix
Date: Mon, 20 Sep 2004 20:40:55 -0700	[thread overview]
Message-ID: <20040920204055.577976a9.akpm@osdl.org> (raw)


I guess I'll merge this into Linus's tree this evening.  It breaks sparc64
and probably other architectures.  The fix will be simple; probably the
same as x86_64..


From: Roland McGrath <roland@redhat.com>

This patch updates the x86-64's compat code to handle the new argument to
waitid.

Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 25-akpm/arch/x86_64/ia32/sys_ia32.c |   11 +++++++++--
 25-akpm/include/linux/syscalls.h    |    3 ++-
 2 files changed, 11 insertions(+), 3 deletions(-)

diff -puN arch/x86_64/ia32/sys_ia32.c~x86-64-waitid-compat-fix arch/x86_64/ia32/sys_ia32.c
--- 25/arch/x86_64/ia32/sys_ia32.c~x86-64-waitid-compat-fix	Mon Sep 20 14:58:27 2004
+++ 25-akpm/arch/x86_64/ia32/sys_ia32.c	Mon Sep 20 14:58:27 2004
@@ -1152,19 +1152,26 @@ asmlinkage long sys32_clone(unsigned int
 }
 
 asmlinkage long sys32_waitid(int which, compat_pid_t pid,
-			     siginfo_t32 __user *uinfo, int options)
+			     siginfo_t32 __user *uinfo, int options,
+			     struct compat_rusage __user *uru)
 {
 	siginfo_t info;
+	struct rusage ru;
 	long ret;
 	mm_segment_t old_fs = get_fs();
 
 	info.si_signo = 0;
 	set_fs (KERNEL_DS);
-	ret = sys_waitid(which, pid, (siginfo_t __user *) &info, options);
+	ret = sys_waitid(which, pid, (siginfo_t __user *) &info, options,
+			 uru ? &ru : NULL);
 	set_fs (old_fs);
 
 	if (ret < 0 || info.si_signo == 0)
 		return ret;
+
+	if (uru && (ret = put_compat_rusage(&ru, uru)))
+		return ret;
+
 	BUG_ON(info.si_code & __SI_MASK);
 	info.si_code |= __SI_CHLD;
 	return ia32_copy_siginfo_to_user(uinfo, &info);
diff -puN include/linux/syscalls.h~x86-64-waitid-compat-fix include/linux/syscalls.h
--- 25/include/linux/syscalls.h~x86-64-waitid-compat-fix	Mon Sep 20 14:58:27 2004
+++ 25-akpm/include/linux/syscalls.h	Mon Sep 20 14:58:27 2004
@@ -163,7 +163,8 @@ asmlinkage void sys_exit_group(int error
 asmlinkage long sys_wait4(pid_t pid, unsigned int __user *stat_addr,
 				int options, struct rusage __user *ru);
 asmlinkage long sys_waitid(int which, pid_t pid,
-			   	struct siginfo __user *infop, int options);
+			   struct siginfo __user *infop,
+			   int options, struct rusage __user *ru);
 asmlinkage long sys_waitpid(pid_t pid, unsigned int __user *stat_addr, int options);
 asmlinkage long sys_set_tid_address(int __user *tidptr);
 asmlinkage long sys_futex(u32 __user *uaddr, int op, int val,
_

             reply	other threads:[~2004-09-21  3:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-21  3:40 Andrew Morton [this message]
2004-09-21  3:46 ` x86-64-waitid-compat-fix Andrew Morton
2004-09-21  6:17   ` x86-64-waitid-compat-fix David S. Miller
2004-09-21  8:54 ` x86-64-waitid-compat-fix Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040920204055.577976a9.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=linux-arch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox