From: Russell King <rmk@arm.linux.org.uk>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Arch list <linux-arch@vger.kernel.org>
Subject: Re: Interrupts & total mess
Date: Thu, 21 Oct 2004 08:26:00 +0100 [thread overview]
Message-ID: <20041021082600.A31133@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1098338732.3939.20.camel@gaston>; from benh@kernel.crashing.org on Thu, Oct 21, 2004 at 04:05:32PM +1000
On Thu, Oct 21, 2004 at 04:05:32PM +1000, Benjamin Herrenschmidt wrote:
> Which is seriously starting to make no sense, especially when you don't
> really know who is including who, with also the strange rule of never
> including linux/irq.h directly from a driver since the arch may not use
> the definitions in there, etc... it's a complete can of worms...
>
> So basically, linux/irq.h should be asm-generic/irq.h right ?
Correct, which is why I recently sent a patch to lkml to remove the
wrongly placed include file - in the hope that someone who cares about
it would fix it as you're suggesting (and that other people can suffer
some of the repeated breakage caused by that misplaced file.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
prev parent reply other threads:[~2004-10-21 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 6:05 Interrupts & total mess Benjamin Herrenschmidt
2004-10-21 6:07 ` Benjamin Herrenschmidt
2004-10-21 7:26 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041021082600.A31133@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox