Re: [RFC] Add NO_IRQ to all architectures

[William Lee Irwin III <wli@holomorphy.com>]

On Tue, Oct 26, 2004 at 12:08:11PM +1000, Benjamin Herrenschmidt wrote:
> Here'd a patch adding a definition of NO_IRQ to all archs
include/asm-*/irq.h. This patch currently defines it to (-1) for all
> archs. IRQ numbers are randomly stored in int's, unsigned int's, or
> all sort of things all over the kernel, but that shouldn't be a
> problem in most cases. NO_IRQ is mostly to be used within a given
> driver, to identify a device for which it has no IRQ assigned. This
> concerns relatively few drivers, like 8250 or IDE.
> At this point, I do _not_ intend to fix the probe_irq_*() API to
> return NO_IRQ instead of 0, that could be done in a second step (or
> x86 NO_IRQ could simply be defined to be 0 ...), but I will fix IDE
> in a subsequent patch.
> It would be nice though if things could slowly get fixed to deal with
> it in a better way.

Maybe wrapping the numbers in a struct for strict typechecking given
some config option, eventually making it mandatory once enough drivers
are swept would make sense.


-- wli