From: Sam Ravnborg <sam@ravnborg.org>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
linux-arch@vger.kernel.org
Subject: Re: i386: use generic support for offsets.h
Date: Fri, 29 Oct 2004 21:05:27 +0200 [thread overview]
Message-ID: <20041029190526.GA8246@mars.ravnborg.org> (raw)
In-Reply-To: <20041029095214.GM11105@lug-owl.de>
On Fri, Oct 29, 2004 at 11:52:14AM +0200, Jan-Benedict Glaw wrote:
> On Thu, 2004-10-28 21:02:21 +0200, Sam Ravnborg <sam@ravnborg.org>
> wrote in message <20041028190221.GD9004@mars.ravnborg.org>:
> > diff -Nru a/include/asm-i386/offsets.c b/include/asm-i386/offsets.c
> > --- /dev/null Wed Dec 31 16:00:00 196900
> > +++ b/include/asm-i386/offsets.c 2004-10-28 20:47:38 +02:00
> > @@ -0,0 +1,66 @@
>
> To be honest, I don't really like to have .c files in the include
> pathes... However, I don't know about a better idea (except maybe to
> place this into ./linux/arch/$(ARCH)/lib/)...
Having the source file in same directory as the result file is a
pattern used all over the kernel. Moving the .c file to include/asm-xxx
just made this true for offsets.h.
In this process a renaming took place so the name of the source file
and the result file match except for the extension.
Some architectures had: asm_offsets.c => offsets.h
A non-logical renaming.
As for the idea of having source file located in a separate
directory. It's not supported by kbuild today, and I'm reluctant
to support it - since it usually triggers misuse.
kbuild is about making the trivial stuff easy, but not about full
flexibility. If we wanted full flexibility we would not have used
so much effort to define a simple syntax.
Sam
next prev parent reply other threads:[~2004-10-29 17:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 18:59 kbuild/all archs: Sanitize creating offsets.h Sam Ravnborg
2004-10-28 19:00 ` New kbuild filename: Kbuild Sam Ravnborg
2004-10-28 17:30 ` Geert Uytterhoeven
2004-10-29 11:59 ` Christoph Hellwig
2004-10-29 19:12 ` Sam Ravnborg
2004-10-29 17:47 ` Roman Zippel
2004-10-29 20:46 ` Sam Ravnborg
2004-10-28 19:01 ` kbuild: generic support for offsets.h Sam Ravnborg
2004-10-28 19:02 ` i386: use " Sam Ravnborg
2004-10-29 9:52 ` Jan-Benedict Glaw
2004-10-29 19:05 ` Sam Ravnborg [this message]
2004-10-28 19:03 ` arm: use generic support for constants.h Sam Ravnborg
2004-10-28 19:44 ` kbuild/all archs: Sanitize creating offsets.h Russell King
2004-10-28 21:59 ` Sam Ravnborg
2004-10-28 21:00 ` Russell King
2004-10-28 23:45 ` Sam Ravnborg
2004-10-29 21:28 ` Sam Ravnborg
2004-10-29 19:51 ` Russell King
2004-10-29 22:36 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029190526.GA8246@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox