From: "David S. Miller" <davem@davemloft.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: akpm@osdl.org, dwmw2@infradead.org, linux-arch@vger.kernel.org
Subject: Re: [patch 19/24] TASK_SIZE is variable.
Date: Fri, 4 Feb 2005 21:52:44 -0800 [thread overview]
Message-ID: <20050204215244.1d2532f7.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0502041919300.2165@ppc970.osdl.org>
On Fri, 4 Feb 2005 19:29:17 -0800 (PST)
Linus Torvalds <torvalds@osdl.org> wrote:
> For example, replacing TASK_SIZE in fs/namei.c with "thread->addr_limit"
> would actually clean up the code: it would mean that the games with
> "get_fs()" etc would just go away, to be replaced with something like
I think that looks nice too.
Would you be against a "mm->addr_limit"? That's what an approach
by Paulus implemented, and I was in the camp supporting that kind
of direction.
"mm"'s exist potentially long after the "thread" part goes away.
That's why my position is that logically any "limit" on the address
space is an mm property.
And thusly, this is what that mmap() et al. stuff should be checking
not some arg'less macro called TASK_SIZE.
As an aside, while I realize the bad side effects of making
USER_PTRS_PER_PGD dynamic, it makes 32-bit process teardown
a lot faster so it's no surprise all the platforms do it.
next prev parent reply other threads:[~2005-02-05 5:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200502050150.j151osl11380@mail.osdl.org>
2005-02-05 2:16 ` [patch 19/24] TASK_SIZE is variable Linus Torvalds
2005-02-05 3:29 ` Linus Torvalds
2005-02-05 5:52 ` David S. Miller [this message]
2005-02-07 10:59 ` David Howells
2005-02-07 19:30 ` David S. Miller
2005-02-08 9:05 ` Martin Schwidefsky
2005-02-08 19:09 ` David S. Miller
2005-02-05 9:06 ` Russell King
2005-02-05 23:44 ` David S. Miller
2005-02-06 10:50 ` Andi Kleen
2005-02-06 21:19 ` David S. Miller
2005-02-06 21:31 ` Andi Kleen
2005-02-06 21:31 ` David S. Miller
2005-02-06 21:50 ` Andi Kleen
2005-02-06 22:25 ` David S. Miller
2005-02-06 22:31 ` David S. Miller
2005-02-07 8:11 ` Andi Kleen
2005-02-07 19:28 ` David S. Miller
2005-02-07 20:15 ` Andi Kleen
2005-02-07 20:13 ` David S. Miller
2005-02-05 6:54 ` Andi Kleen
2005-02-05 7:18 ` Andrew Morton
2005-02-05 7:40 ` Andi Kleen
2005-02-05 23:27 ` David S. Miller
2005-02-06 10:38 ` Andi Kleen
2005-02-06 13:05 ` Matthew Wilcox
2005-02-05 23:15 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050204215244.1d2532f7.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox