From: Matthew Wilcox <matthew@wil.cx>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-arch@vger.kernel.org, Roland McGrath <roland@redhat.com>
Subject: [PATCH] Remove spurious BUG from posix-cpu-timers
Date: Sat, 19 Mar 2005 04:45:03 +0000 [thread overview]
Message-ID: <20050319044503.GK21986@parcelfarce.linux.theplanet.co.uk> (raw)
PA-RISC does not necessarily have interrupts disabled while timers are
running. This doesn't appear to be a requirement, but posix-cpu-timers
seems to think it is.
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
diff -urpNX dontdiff linus-2.6/kernel/posix-cpu-timers.c parisc-2.6/kernel/posix-cpu-timers.c
--- linus-2.6/kernel/posix-cpu-timers.c 2005-03-18 05:55:27.000000000 -0700
+++ parisc-2.6/kernel/posix-cpu-timers.c 2005-03-18 13:52:53.341505966 -0700
@@ -1242,8 +1242,6 @@ void run_posix_cpu_timers(struct task_st
LIST_HEAD(firing);
struct k_itimer *timer, *next;
- BUG_ON(!irqs_disabled());
-
#define UNEXPIRED(clock) \
(tsk->it_##clock##_expires == 0 || \
cputime_lt(clock##_ticks(tsk), tsk->it_##clock##_expires))
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next reply other threads:[~2005-03-19 4:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 4:45 Matthew Wilcox [this message]
2005-03-19 4:53 ` [PATCH] Remove spurious BUG from posix-cpu-timers Andrew Morton
2005-03-19 4:59 ` Matthew Wilcox
2005-03-20 7:38 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050319044503.GK21986@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=linux-arch@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox