Re: [PATCH] Remove spurious BUG from posix-cpu-timers

[Matthew Wilcox <matthew@wil.cx>]

On Fri, Mar 18, 2005 at 08:53:34PM -0800, Andrew Morton wrote:
> Matthew Wilcox <matthew@wil.cx> wrote:
> >
> > 
> > PA-RISC does not necessarily have interrupts disabled while timers are
> > running.  This doesn't appear to be a requirement, but posix-cpu-timers
> > seems to think it is.
> > 
> 
> But a bit later on we do
> 
>         spin_lock(&tsk->sighand->siglock);
> 
> rather than spin_lock_irqsave()?

We're in interrupt context ... we're ok, unless another interrupt handler
tries to take the same spinlock.  Maybe the posix cpu timer code should
be using _irqsave anyway?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain