Re: [PATCH] consolidate shmat usage

[Matthew Wilcox <matthew@wil.cx>]

On Tue, Apr 05, 2005 at 06:01:32PM +1000, Stephen Rothwell wrote:
> On Wed, 23 Mar 2005 14:51:32 +0000 Matthew Wilcox <matthew@wil.cx> wrote:
> > I dislike the naming here.  The manpage for shmat is the three-argument
> > version.  The only reason we have the four-argument version is because
> > of the silly sys_ipc multiplexer.  So I think sys_shmat() should be
> > the three-argument form and we should rename the existing sys_shmat()
> > to something like ipc_shmat().  Does it need to be asmlinkage?
> 
> OK, I have changed sys_shmat to sys_shmat4 and sys_shmatcall to sys_shmat.
> There are some architectures that use each of these directly as system
> calls.

Umm.  I think you've just discovered a bug in ARM and MIPS.  I don't see
any code in glibc for handling the 4-argument version of sys_shmat.
Russell, Ralf, could you comment?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain