Re: [RFC] unify semaphore implementations

David S. Miller
2005-04-28T18:53:44Z

On Thu, 28 Apr 2005 14:59:56 -0400
Benjamin LaHaise <bcrl@kvack.org> wrote:

> On Thu, Apr 28, 2005 at 11:48:09AM -0700, James Bottomley wrote:
> > Could you come up with a less monolithic way to share this so that we
> > can still do a spinlock semaphore implementation instead of an atomic op
> > based one?
>
> As I read the code, it doesn't make a difference: parisc will take a
> spin lock within the atomic operation and then release it, which makes
> the old fast path for the semaphores and the new fast path pretty much
> equivalent (they both take and release one spinlock).

I think parisc should be allowed to choose their implementation of
semaphores. Look, if you change semaphores in some way it will
be their problem to keep their parisc version in sync.

Or you could provide both a spinlocked and an atomic op based implementation
of generic semaphores, as we do for rwsem already.