public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: torvalds@osdl.org, linux-arch@vger.kernel.org
Subject: iomap interface issue
Date: Tue, 3 May 2005 10:47:56 +1000	[thread overview]
Message-ID: <20050503004756.GB12682@krispykreme> (raw)


Hi,

I was looking through the iomap API and noticed that pci_iounmap only
takes a pci_dev and address:

void pci_iounmap(struct pci_dev *dev, void __iomem *addr)

At the moment the ppc64 interface does nothing on iounmap, but for
hotplug we need to tear down MMU entries associated with MMIO regions.
This is because we need to ensure all entries are removed before the
adapter is moved to another partition (or else the old partition could
still access the device).

With the current API we could work out if an address is IO or MMIO but
it will be a bit ugly. I was wondering if it made sense to pass in the
BAR to pci_iounmap. That would make it easy to work out if its an MMIO
region.

Anton

             reply	other threads:[~2005-05-03  0:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-03  0:47 Anton Blanchard [this message]
2005-05-03  2:26 ` iomap interface issue David S. Miller
2005-05-03  3:11   ` Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050503004756.GB12682@krispykreme \
    --to=anton@samba.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox