public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-arch@vger.kernel.org, apw@shadowen.org,
	haveblue@us.ibm.com, matthew.e.tolentino@intel.com,
	bob.picco@hp.com
Subject: Re: sparsemem patches in -mm
Date: Tue, 21 Jun 2005 23:00:24 -0700	[thread overview]
Message-ID: <20050621230024.4cd8d2fd.akpm@osdl.org> (raw)
In-Reply-To: <20050621.224645.78710941.davem@davemloft.net>

"David S. Miller" <davem@davemloft.net> wrote:
>
> From: Andrew Morton <akpm@osdl.org>
> Date: Tue, 21 Jun 2005 02:13:52 -0700
> 
> > http://www.zip.com.au/~akpm/linux/patches/stuff/sparsemem/
> 
> The only thing that sticks out to me in this patch is that
> sparc64 uses a field starting at bit 24 in page->flags to
> determine the cpu which needs a D-cache flush for a page.

<looks>

That's a bit hacky.  Doesn't it conflict with the way in which we stuff the
page's zone index into the top of page->flags?  I guess with a small number
of zones and a smallish number of CPUs you got lucky.

It'd be safer to use bit 32.

> I don't think the page->flags rework makes things any different
> than before, but it's something to keep in mind.

Think so.

  reply	other threads:[~2005-06-22  6:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-21  9:13 sparsemem patches in -mm Andrew Morton
2005-06-21  9:50 ` Andi Kleen
2005-06-21 10:09   ` Andrew Morton
2005-06-21 15:49   ` Andy Whitcroft
2005-06-21 15:58     ` Andi Kleen
2005-06-21 11:00 ` Bob Picco
2005-06-21 15:57   ` Dave Hansen
2005-06-21 16:45     ` Bob Picco
2005-06-21 14:17 ` Matthew Wilcox
2005-06-21 15:51   ` Andy Whitcroft
2005-06-21 20:01     ` Andrew Morton
2005-06-21 23:39       ` Dave Hansen
2005-06-22  5:46 ` David S. Miller
2005-06-22  6:00   ` Andrew Morton [this message]
2005-07-27 22:42     ` David S. Miller
2005-06-23 22:48 ` Roman Zippel
2005-06-23 22:56   ` Dave Hansen
2005-06-23 23:53     ` Roman Zippel
  -- strict thread matches above, loose matches on Subject: below --
2005-06-21 15:52 Luck, Tony
2005-06-21 15:58 ` Andy Whitcroft
2005-06-21 16:09 Luck, Tony
2005-06-21 16:17 ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050621230024.4cd8d2fd.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=bob.picco@hp.com \
    --cc=davem@davemloft.net \
    --cc=haveblue@us.ibm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=matthew.e.tolentino@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox