From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-arch@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: spinlock-consolidation.patch
Date: Mon, 12 Sep 2005 11:27:10 +0200 [thread overview]
Message-ID: <20050912092710.GB5731@elte.hu> (raw)
In-Reply-To: <20050909121521.12942a8d.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> Guys, I'm planning on sending this Linuswards in about two days time.
> There's never a right time for this sort of thing and there may be
> some relatively trivial breakage for architectures I don't test for.
> But it kills 1300 lines of code.
the patch goes far beyond code reduction effects: the patch also unifies
and centralizes all known spinlock-debugging features, which improves
every architecture. E.g. on x86 we can now detect spinlock deadlocks
even without the NMI watchdog. Even the architecture with the most
advanced lowlevel spinlock-debugging framework (Sparc) gets improved a
bit by this [by getting additional rwlock debugging code].
If i missed any spinlock-debugging cleverness then please holler and
i'll add it to the generic code.
Ingo
ps. also, with this patch the ATOMIC_DEC_AND_LOCK uglinesses have
finally become history
ps2. and PREEMPT_RT gets a central spinlock type to fiddle with ;-)
next prev parent reply other threads:[~2005-09-12 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 19:15 spinlock-consolidation.patch Andrew Morton
2005-09-09 19:50 ` spinlock-consolidation.patch David S. Miller
2005-09-09 23:52 ` spinlock-consolidation.patch Roman Zippel
2005-09-12 9:27 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-09 21:04 spinlock-consolidation.patch Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050912092710.GB5731@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox