From: Matthew Wilcox <matthew@wil.cx>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: viro@ZenIV.linux.org.uk, Linus Torvalds <torvalds@osdl.org>,
linux-arch@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] killing linux/irq.h
Date: Thu, 15 Sep 2005 10:34:55 -0600 [thread overview]
Message-ID: <20050915163455.GD16698@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0509110949390.30752@numbat.sonytel.be>
On Sun, Sep 11, 2005 at 09:50:38AM +0200, Geert Uytterhoeven wrote:
> On Fri, 9 Sep 2005 viro@ZenIV.linux.org.uk wrote:
> > We get regular portability bugs when somebody decides to include
> > linux/irq.h into a driver instead of asm/irq.h. It's almost always a
> > wrong thing to do and, in fact, causes immediate breakage on e.g. arm.
>
> Wouldn't it be more logical to make linux/irq.h the preferred include?
> Usually the linux/* versions are preferred over the asm/* versions.
There's almost no reason to want <*/irq.h> in the first place. Almost
all drivers really want <linux/interrupt.h>
next prev parent reply other threads:[~2005-09-15 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 18:42 [RFC] killing linux/irq.h viro
2005-09-11 7:50 ` Geert Uytterhoeven
2005-09-15 16:34 ` Matthew Wilcox [this message]
2005-09-15 16:40 ` Russell King
2005-09-15 16:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050915163455.GD16698@parisc-linux.org \
--to=matthew@wil.cx \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox