From: Russell King <rmk@arm.linux.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-arch@vger.kernel.org
Subject: Re: irq-type-flags.patch
Date: Wed, 9 Nov 2005 13:24:49 +0000 [thread overview]
Message-ID: <20051109132449.GC4712@flint.arm.linux.org.uk> (raw)
In-Reply-To: <26691.1131542400@warthog.cambridge.redhat.com>
On Wed, Nov 09, 2005 at 01:20:00PM +0000, David Howells wrote:
> Andrew Morton <akpm@osdl.org> wrote:
>
> > + desc->chip->set_type(irq, type);
>
> How's the error handled if the PIC can't handle the requested type?
>
> It seems like it ought to be wrong that the driver is setting this. It ought
> to be a property of the arch or the bus.
No it should not. Neither the arch not the bus dictates what the
device manufacturer decides to do with their interrupt output.
It most definitely is a property of the device/driver and not a
higher level.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-11-09 13:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 3:10 irq-type-flags.patch Andrew Morton
2005-11-09 9:26 ` irq-type-flags.patch William Lee Irwin III
2005-11-09 13:20 ` irq-type-flags.patch David Howells
2005-11-09 13:24 ` Russell King [this message]
2005-11-09 15:13 ` irq-type-flags.patch David Howells
2005-11-09 15:27 ` irq-type-flags.patch Russell King
2005-11-09 16:07 ` irq-type-flags.patch David Howells
2005-11-09 13:30 ` irq-type-flags.patch Paul Mundt
2005-11-09 13:49 ` irq-type-flags.patch Matthew Wilcox
2005-11-09 14:40 ` irq-type-flags.patch Paul Mundt
2005-11-09 14:47 ` irq-type-flags.patch Russell King
2005-11-09 15:26 ` irq-type-flags.patch Matthew Wilcox
2005-11-09 15:28 ` irq-type-flags.patch Russell King
2005-11-10 14:06 ` irq-type-flags.patch Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051109132449.GC4712@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox