Re: irq-type-flags.patch

[Russell King <rmk@arm.linux.org.uk>]

On Wed, Nov 09, 2005 at 08:26:59AM -0700, Matthew Wilcox wrote:
> On Wed, Nov 09, 2005 at 02:47:58PM +0000, Russell King wrote:
> > On Wed, Nov 09, 2005 at 06:49:32AM -0700, Matthew Wilcox wrote:
> > > On Wed, Nov 09, 2005 at 03:30:23PM +0200, Paul Mundt wrote:
> > > > > +#define SA_TRIGGER_LOW		0x00000004
> > > > > +#define SA_TRIGGER_RISING	0x00000002
> > > > > +#define SA_TRIGGER_FALLING	0x00000001
> > > > It probably makes sense to move SA_TRIGGER here as well, as it's going to
> > > > be a pretty common mask. Otherwise everyone that plans to make use of
> > > > this will likely end up duplicating it.
> > > 
> > > Are there any other architectures that plan to make use of this?
> > 
> > Just to be clear - the primary reason I'm putting these in a shared
> > file is that we don't want to add #ifdefs to drivers (which is what
> > would be necessary if it was placed in asm-arm.)
> 
> Certainly.  The question is whether it makes sense to put the SA_TRIGGER
> define (being the | of all these) in arch files or in the common files.
> And it sounds like since SH also needs to use this, that should also go
> in adjacent to the SA_TRIGGER_* defines.

I'm fine with moving it there.  Shall I do a new patch?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core