Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

Christoph Hellwig
2005-12-13T09:21:16Z

On Tue, Dec 13, 2005 at 01:14:13AM -0800, Andrew Morton wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Tue, Dec 13, 2005 at 12:42:57AM -0800, Andrew Morton wrote:
> > > scsi/sd.c is currently getting an ICE. None of the new SAS code compiles,
> > > due to extensive use of anonymous unions.
> >
> > This is just the headers in the luben code which need redoing completely
> > because they're doing other stupid things like using bitfields for on the
> > wire structures.
>
> Don't think so (you're referring to Jeff's git-sas-jg.patch?). It dies
> with current -linus tree.

I didn't mean sd.c but the anonymous union usage. Everything that's stuffed
into include/scsi/sas/ in -mm is far from mergeable. It's really badly done
headers that need to be redone.