Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

Arjan van de Ven
2005-12-13T09:19:30Z

On Tue, 2005-12-13 at 10:03 +0100, Ingo Molnar wrote:
> * Arjan van de Ven <arjan@infradead.org> wrote:
>
> > > even better than that, why not use the solution that we've implemented
> > > for the -rt patchset, more than a year ago?
> > >
> > > the solution i took was this:
> > >
> > > - i did not touch the 'struct semaphore' namespace, but introduced a
> > > 'struct compat_semaphore'.
> >
> > which I think is wrong. THis naming sucks. Sure doing a full sed on
> > the tree is not pretty but it's also not THAT painful. And the pain of
> > wrong names is something the kernel needs to carry around for years.
>
> well, i'm all for renaming struct semaphore to struct mutex, but dont
> the same arguments apply as to 'struct timer_list'?

don't think so; this is not a "lets do them one by one over the year",
this is a "do them all right now at once" move.