From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 3/3] sanitize building of fs/compat_ioctl.c
Date: Tue, 13 Dec 2005 10:34:34 -0700 [thread overview]
Message-ID: <20051213173434.GP9286@parisc-linux.org> (raw)
In-Reply-To: <20051213172325.GC16392@lst.de>
On Tue, Dec 13, 2005 at 06:23:25PM +0100, Christoph Hellwig wrote:
> [1] parisc still had it's PPP handler left, which is not fully correct
> for ppp and besides that ppp uses the generic SIOCPRIV ioctl so it'd
> kick in for all netdevice users. We can introduce a proper handler
> in one of the next patch series by adding a compat_ioctl method to
> struct net_device but for now let's just kill it - parisc doesn't
> compile in mainline anyway and I don't want this to block this
> patchset.
parisc probably does compile in mainline these days. It's certainly
much closer than it ever was before. The 64-bit code doesn't compile
because Andi keeps blocking the is_compat_task() stuff. Why not do the
netdevice compat_ioctl patch before killing this? I'd hate to have to
back out this patch in the PA tree.
next prev parent reply other threads:[~2005-12-13 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 17:23 [PATCH 3/3] sanitize building of fs/compat_ioctl.c Christoph Hellwig
2005-12-13 17:34 ` Matthew Wilcox [this message]
2005-12-13 22:51 ` David S. Miller
2005-12-13 22:53 ` Matthew Wilcox
2005-12-13 23:00 ` David S. Miller
2005-12-14 1:41 ` Andi Kleen
2005-12-14 2:23 ` David S. Miller
2005-12-14 2:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213173434.GP9286@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox