public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: anton@samba.org
Cc: linux-arch@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: Adding compat_ptrace_request
Date: Mon, 09 Jan 2006 01:03:55 -0800 (PST)	[thread overview]
Message-ID: <20060109.010355.69867251.davem@davemloft.net> (raw)
In-Reply-To: <20060109065914.GS26499@krispykreme>

From: Anton Blanchard <anton@samba.org>
Date: Mon, 9 Jan 2006 17:59:14 +1100

> We noticed 32/64bit compat issues with GETSIGINFO and SETSIGINFO. It
> looks like s390 are already fixing this up in architecture specific
> code, but here is a patch from Stephen Rothwell to add some generic
> compat ptrace helpers.
> 
> Look OK? 

Looks not too bad, although...

> +		return copy_siginfo_to_user32(data, &lastinfo);

It would be nice to rename this copy_siginfo things to not
have "32" and instead "compat" in their names.

  reply	other threads:[~2006-01-09  9:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-09  6:59 Adding compat_ptrace_request Anton Blanchard
2006-01-09  9:03 ` David S. Miller [this message]
2006-01-09 12:00   ` Stephen Rothwell
2006-01-09 20:51     ` David S. Miller
2006-01-09 12:19 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060109.010355.69867251.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anton@samba.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox