public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: linux-arch@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Cc: carlos neira <cneira@srb.cl>
Subject: sys_pciconfig_{read,write}
Date: Mon, 9 Jan 2006 09:27:18 -0700	[thread overview]
Message-ID: <20060109162718.GP19769@parisc-linux.org> (raw)


I bet most people don't even know we have these syscalls.  But they're
built into every arch except X86, and only hooked up on alpha, arm,
ia64, ppc32, sparc and sparc64.

Given the existence of sysfs and the inability of the syscalls to handle
domains, I don't see any point in hooking them up on new architectures.
I suspect they could even be deleted since any software trying them must
fall back to other methods to be portable.

The syscalls also take the BKL, as pointed out by Carlos on kernel janitors.
This is unnecessary as they're already spinlocked at a lower level.

So I propose the following three patches:

1/ New Kconfig symbol CONFIG_PCI_SYSCALLS to be defined by the above
architectures.  Makefile altered accordingly.

2/ Removal of BKL from syscall implementation.

3/ Removal of !CONFIG_PCI pciconfig stubs from alpha, ia64 and sparc64
(we already have cond_syscalls for them).

I don't quite understand why we need
compat_sys_pciconfig_{read,write,iobase} on ppc64.  Can't these just
call the normal versions?

             reply	other threads:[~2006-01-09 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-09 16:27 Matthew Wilcox [this message]
2006-01-09 23:36 ` Subject: [PATCH] powerpc: remove compat_sys_pciconfig_* Stephen Rothwell
2006-01-09 23:37 ` sys_pciconfig_{read,write} Stephen Rothwell
2006-01-20 10:00 ` sys_pciconfig_{read,write} David S. Miller
2006-01-20 12:10   ` sys_pciconfig_{read,write} Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060109162718.GP19769@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=cneira@srb.cl \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox