From: "David S. Miller" <davem@davemloft.net>
To: ak@suse.de
Cc: kyle@parisc-linux.org, linux-arch@vger.kernel.org
Subject: Re: [RFC] is_compat_task helper
Date: Mon, 23 Jan 2006 21:07:55 -0800 (PST) [thread overview]
Message-ID: <20060123.210755.31638992.davem@davemloft.net> (raw)
In-Reply-To: <200601240113.39825.ak@suse.de>
From: Andi Kleen <ak@suse.de>
Date: Tue, 24 Jan 2006 01:13:39 +0100
> On Tuesday 24 January 2006 01:07, Kyle McMartin wrote:
>
> > +/* Arches may override __is_compat_task from asm/compat.h */
> > +#ifndef __is_compat_task
> > +#define __is_compat_task(x) (personality(x->personality) == PER_LINUX32)
>
> I don't think this particular patch is a good idea. PER_LINUX32 means
> something completely different than you think on many architectures.
> You can't do a default for it.
Indeed, it is definitely preferable to just flat out break
the build than give a bogus default.
If the build breaks, you see the failure and the platform
maintainer makes sure the correct implementation is made.
If it silently just builds, you end up with potential silent
failures which just sucks :)
next prev parent reply other threads:[~2006-01-24 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 0:07 [RFC] is_compat_task helper Kyle McMartin
2006-01-24 0:13 ` Andi Kleen
2006-01-24 0:23 ` Kyle McMartin
2006-01-24 5:07 ` David S. Miller [this message]
2006-01-25 16:34 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060123.210755.31638992.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@suse.de \
--cc=kyle@parisc-linux.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox