public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Kyle McMartin <kyle@parisc-linux.org>
Cc: linux-arch@vger.kernel.org
Subject: Re: [RFC] is_compat_task helper
Date: Tue, 24 Jan 2006 01:13:39 +0100	[thread overview]
Message-ID: <200601240113.39825.ak@suse.de> (raw)
In-Reply-To: <20060124000753.GC5604@quicksilver.road.mcmartin.ca>

On Tuesday 24 January 2006 01:07, Kyle McMartin wrote:

> +/* Arches may override __is_compat_task from asm/compat.h */
> +#ifndef __is_compat_task
> +#define __is_compat_task(x)	(personality(x->personality) == PER_LINUX32)

I don't think this particular patch is a good idea. PER_LINUX32 means
something completely different than you think on many architectures.
You can't do a default for it.

-Andi

  reply	other threads:[~2006-01-24  0:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-24  0:07 [RFC] is_compat_task helper Kyle McMartin
2006-01-24  0:13 ` Andi Kleen [this message]
2006-01-24  0:23   ` Kyle McMartin
2006-01-24  5:07   ` David S. Miller
2006-01-25 16:34     ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601240113.39825.ak@suse.de \
    --to=ak@suse.de \
    --cc=kyle@parisc-linux.org \
    --cc=linux-arch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox