From: Russell King <rmk@arm.linux.org.uk>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-arch@vger.kernel.org, Jan Beulich <JBeulich@novell.com>
Subject: Re: Fw: [PATCH] abstract type/size specification for assembly
Date: Wed, 1 Feb 2006 08:32:43 +0000 [thread overview]
Message-ID: <20060201083243.GB24893@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200602010836.09932.ak@suse.de>
On Wed, Feb 01, 2006 at 08:36:09AM +0100, Andi Kleen wrote:
> On Tuesday 31 January 2006 23:31, Andrew Morton wrote:
> >
> > OK?
>
> Yes.
No.
> > +#define ENDPROC(name) \
> > + .type name, @function; \
> > + END(name)
> > +#define END(name) \
> > + .size name, .-name
@ is the comment character on ARM, so this can't go here - we use
.type name, %function
instead. Interestingly, the info pages for as seem to indicate that
there's a number of alternatives - maybe the most benign one should
be used, iow:
.type name, "function"
or alternatively make ENDPROC arch-overridable.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-02-01 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 22:31 Fw: [PATCH] abstract type/size specification for assembly Andrew Morton
2006-02-01 7:36 ` Andi Kleen
2006-02-01 8:32 ` Russell King [this message]
2006-02-01 8:49 ` Andi Kleen
2006-02-01 9:09 ` Russell King
2006-02-01 11:40 ` Jan Beulich
2006-02-08 16:11 ` Jan Beulich
2006-02-01 13:50 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060201083243.GB24893@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=JBeulich@novell.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox