Re: percpu data changes

[Andrew Morton <akpm@osdl.org>]

Andrew Morton <akpm@osdl.org> wrote:
>
> Andrew Morton <akpm@osdl.org> wrote:
>  >
>  > I have a patch queued up (for 2.6.16) which fixes most users of percpu
>  >  data.  Make them use for_each_cpu().  I'll send that in a moment.

A couple more.


 net/core/dev.c   |    2 +-
 net/core/utils.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff -puN net/core/dev.c~reduce-size-of-percpudata-and-make-sure-per_cpuobject-update net/core/dev.c
--- devel/net/core/dev.c~reduce-size-of-percpudata-and-make-sure-per_cpuobject-update	2006-02-03 01:33:56.000000000 -0800
+++ devel-akpm/net/core/dev.c	2006-02-03 01:34:16.000000000 -0800
@@ -3237,7 +3237,7 @@ static int __init net_dev_init(void)
 	 *	Initialise the packet receive queues.
 	 */
 
-	for (i = 0; i < NR_CPUS; i++) {
+	for_each_cpu(i) {
 		struct softnet_data *queue;
 
 		queue = &per_cpu(softnet_data, i);
diff -puN net/core/utils.c~reduce-size-of-percpudata-and-make-sure-per_cpuobject-update net/core/utils.c
--- devel/net/core/utils.c~reduce-size-of-percpudata-and-make-sure-per_cpuobject-update	2006-02-03 01:33:56.000000000 -0800
+++ devel-akpm/net/core/utils.c	2006-02-03 01:34:31.000000000 -0800
@@ -133,7 +133,7 @@ static int net_random_reseed(void)
 	unsigned long seed[NR_CPUS];
 
 	get_random_bytes(seed, sizeof(seed));
-	for (i = 0; i < NR_CPUS; i++) {
+	for_each_cpu(i) {
 		struct nrnd_state *state = &per_cpu(net_rand_state,i);
 		__net_srandom(state, seed[i]);
 	}
_