public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: akpm@osdl.org, linux-arch@vger.kernel.org, mingo@elte.hu
Subject: Re: [patch 1/1] Fix spinlock debugging delays to not time out too early
Date: Tue, 7 Feb 2006 19:29:24 +0100	[thread overview]
Message-ID: <200602071929.24762.ak@muc.de> (raw)
In-Reply-To: <B8E391BBE9FE384DAA4C5C003888BE6F05A3DB05@scsmsx401.amr.corp.intel.com>

On Tuesday 07 February 2006 19:20, Luck, Tony wrote:
> > The fix is to include a __delay(1) call in the loop, to correctly approximate
> > the intended delay timeout of 1 second.  The code assumes that every
> > architecture implements __delay(1) to last around 1/(loops_per_jiffy*HZ)
> > seconds.
> 
> But we calculate loops_per_jiffy based on somewhat larger vales passed
> to __delay() ... where the function call overhead is amortized away.
>
> I'd expect that __delay(1) would last quite a bit longer than
> 1/(loops_per_jiffy * HZ) ... so we'll wait a lot more than a
> second.

For this case that would be ok, as long as it isn't a hour or so,
but let's say < 1 minute.

-Andi


  reply	other threads:[~2006-02-07 18:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-07 18:20 [patch 1/1] Fix spinlock debugging delays to not time out too early Luck, Tony
2006-02-07 18:29 ` Andi Kleen [this message]
2006-02-07 18:44   ` Luck, Tony
2006-02-07 19:14     ` Ingo Molnar
2006-02-07 19:37       ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2006-02-07 17:41 akpm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200602071929.24762.ak@muc.de \
    --to=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox