From: "David S. Miller" <davem@davemloft.net>
To: James.Bottomley@steeleye.com
Cc: linux-arch@vger.kernel.org
Subject: Re: Potential problem with the page_mapping macro and flush_dcache_page()
Date: Sun, 19 Mar 2006 12:33:20 -0800 (PST) [thread overview]
Message-ID: <20060319.123320.71795946.davem@davemloft.net> (raw)
In-Reply-To: <1142788559.3240.30.camel@mulgrave.il.steeleye.com>
From: James Bottomley <James.Bottomley@SteelEye.com>
Date: Sun, 19 Mar 2006 11:15:58 -0600
> The problem, essentially is that get_user_pages() doesn't return a
> coherent view of anonymous pages to the kernel. The reason is that
> get_user_pages() uses flush_dcache_page() as its engine of coherence,
> and a lot of flush_dcache_page() implementations use the page_mapping()
> macros to get a list of user mappings of the page. The page_mapping()
> macro (include/linux/mm.h) returns NULL if the PAGE_MAPPING_ANON flag is
> set, this means that flush_dcache_page() has no list of user mappings,
> so nothing gets flushed in user space.
>
> A lot of arch's don't have an incoherent view of user and kernel
> mappings, so I think this problem perhaps affects only parisc and arm.
flush_dcache_page() implementations intentionally don't operate on
anonymous pages because the kernel should only ever access anonymous
pages via:
1) copy_user_highpage()/clear_user_highpage(), where you can
handle the D-cache issues there.
2) device DMA, where the L2 cache eviction done by the device DMA
will pull out the D-cache entries, or if the block I/O is via PIO
it will do cache flushing in there, as per some asm-*/ide.h
implementations of __ide_ins*()/__ide_outs*()
3) ptrace poking
You've found a case that doesn't go through any special interfaces,
and thus is not handled properly at the current time.
next prev parent reply other threads:[~2006-03-19 20:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 17:15 Potential problem with the page_mapping macro and flush_dcache_page() James Bottomley
2006-03-19 20:33 ` David S. Miller [this message]
2006-03-19 20:53 ` James Bottomley
2006-03-19 21:00 ` David S. Miller
2006-03-19 21:04 ` James Bottomley
2006-03-19 21:23 ` James Bottomley
2006-03-19 21:26 ` David S. Miller
2006-03-19 23:50 ` James Bottomley
2006-03-20 1:15 ` James Bottomley
2006-03-19 21:25 ` David S. Miller
2006-03-19 21:29 ` James Bottomley
2006-03-19 22:01 ` David S. Miller
2006-03-19 23:39 ` James Bottomley
2006-03-19 23:42 ` David S. Miller
2006-03-23 6:20 ` Andrew Morton
2006-03-23 14:13 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060319.123320.71795946.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@steeleye.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox