public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/2] create struct compat_timex and use it everywhere
Date: Thu, 23 Mar 2006 11:09:22 -0800	[thread overview]
Message-ID: <20060323190922.GA13695@agluck-lia64.sc.intel.com> (raw)
In-Reply-To: <20060323185234.GA13486@agluck-lia64.sc.intel.com>

On Thu, Mar 23, 2006 at 10:52:34AM -0800, Luck, Tony wrote:
> Applied this and patch #2 ... builds cleanly on ia64.  I don't have
> a handy test case to confirm that adjtimex works (but since the old
> version was inside "#ifdef NOTYET", it's probably safe to assume that
> this patch is a step forward).

Oh ... but since we didn't have adjtimex implemented, it wasn't
hooked into the syscall table.  This additional patch does that.
I'm in two minds whether it would be useful to add (nobody has
complained about the lack of 32-bit adjtimex support so far, so
this may be all risk, with no benefit).

Add it if you like.

Signed-off-by: Tony Luck <tony.luck@intel.com>


diff --git a/arch/ia64/ia32/ia32_entry.S b/arch/ia64/ia32/ia32_entry.S
index 95fe044..9cb61a3 100644
--- a/arch/ia64/ia32/ia32_entry.S
+++ b/arch/ia64/ia32/ia32_entry.S
@@ -334,7 +334,7 @@ ia32_syscall_table:
 	data8 sys_setdomainname
 	data8 sys32_newuname
 	data8 sys32_modify_ldt
-	data8 sys_ni_syscall	/* adjtimex */
+	data8 sys32_adjtimex
 	data8 sys32_mprotect	  /* 125 */
 	data8 compat_sys_sigprocmask
 	data8 sys_ni_syscall	/* create_module */

  reply	other threads:[~2006-03-23 19:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-23  5:46 [PATCH 1/2] create struct compat_timex and use it everywhere Stephen Rothwell
2006-03-23  5:48 ` [PATCH 2/2] consolidate sys32/compat_adjtimex Stephen Rothwell
2006-03-24 10:09   ` Paul Mackerras
2006-03-23  6:36 ` [PATCH 1/2] create struct compat_timex and use it everywhere Miles Bader
2006-03-23  6:47   ` Stephen Rothwell
2006-03-23  8:17     ` David S. Miller
2006-03-23 14:21 ` Kyle McMartin
2006-03-23 18:52 ` Luck, Tony
2006-03-23 19:09   ` Luck, Tony [this message]
2006-03-23 19:18     ` Luck, Tony
2006-03-27  2:36       ` Stephen Rothwell
2006-03-24 10:09 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060323190922.GA13695@agluck-lia64.sc.intel.com \
    --to=tony.luck@intel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox